Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildscript and resource data to 1.14.4 #1292

Merged
merged 9 commits into from Nov 7, 2019

Conversation

@HyCraftHD
Copy link
Contributor

HyCraftHD commented Nov 7, 2019

This pull updates the buildscript files and basic resources to minecraft 1.14.4.

Don't know if that should be in the main branch or an extra 1.14.4 branch.

HyCraftHD added 9 commits Nov 7, 2019
…with a path
@Shadows-of-Fire

This comment has been minimized.

Copy link
Collaborator

Shadows-of-Fire commented Nov 7, 2019

Targeting main is fine for 1.14, as 1.12 has been split off to a 1.12 branch.
Will review in a bit

@canitzp

This comment has been minimized.

Copy link
Collaborator

canitzp commented Nov 7, 2019

I already did this in my local branch, but i'm fine with this

@Shadows-of-Fire

This comment has been minimized.

Copy link
Collaborator

Shadows-of-Fire commented Nov 7, 2019

Theres a couple changes I'd make to this but they can wait for now.

@Shadows-of-Fire Shadows-of-Fire merged commit 5cf1d2e into Ellpeck:master Nov 7, 2019
@HyCraftHD

This comment has been minimized.

Copy link
Contributor Author

HyCraftHD commented Nov 7, 2019

Okay thanks.
@canitzp Which part do you try to port? So we don't do the same

@canitzp

This comment has been minimized.

Copy link
Collaborator

canitzp commented Nov 7, 2019

actually I don't have a clue and also not a lot of time. I just thought that nobody would do it, so I started in the ten minutes I had

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.