Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.5.4 #286

merged 60 commits into from Mar 15, 2019


None yet
3 participants
Copy link

Solanya commented Mar 15, 2019

No description provided.

Ellypse and others added some commits Jan 17, 2019

Add luacheck config and fix all warning
- Added proper luacheck config to analyse the entire code of the add-on for anti-pattern and incorrect usages.
- Fixed all warning in the existing code raised by luacheck.
- Remove Total RP 2, FlagRSP and FlagRSP2 importers as they probably no longer work anyway.
Merge branch 'development' into luacheck
# Conflicts:
#	totalRP3/modules/register/characters/register_main.lua
#	totalRP3/totalRP3.lua
Merge pull request #267 from Ellypse/luacheck
Project organization improvements
Merge branch 'development' into feature/msp_fields_update
# Conflicts:
#	totalRP3/core/impl/globals.lua
#	totalRP3/modules/register/characters/register_characteristics.lua
#	totalRP3/modules/register/characters/register_ui_characteristics.xml
#	totalRP3/modules/register/main/register_tooltip.lua
#	totalRP3/modules/register/msp/register_msp.lua
Merge branch 'master' into development
# Conflicts:
#	totalRP3/core/impl/globals.lua
Refactor trial account flag to use Player model
Prefer new Player model and object oriented methods to access the trial account flag for both the current user and other players.

Ellypse and others added some commits Feb 11, 2019

Fix long special char lines in T3 profiles
Some people like to draw fancy boxes but there's a weird bug that
I'm tempted to blame Blizzard for, however we trigger it by not
having set the NonSpaceWrap flag set on our fontstring views.

Fix map scans
Your linting god can't save you now.

A few fully qualified field names never had upvalues created so
tooltips for map scans were utterly buggered.

Rather than upvalue them I've just made the references explicit,
because excessive upvalues are an overoptimisation in this case.
Fix additional huge references
I suppose you could say it's a "huge" commit.
Merge pull request #276 from Ellypse/bugfix/remove_msp_t3_setting
Removed "Use template 3 only" setting
Merge pull request #279 from Ellypse/bugfix/wrap-template3-texts
Fix long special char lines in T3 profiles
Added a fix in the changelog
I'll add it to the in-game changelog when I get to add allied races icons + new musics/icons/images
Correctly clear msp.char on registry deletion
deleteProfile was being called in such a way that it would never
emit an event with the mspOwners table populated, thus the handler
in the MSP module would never clear msp.chars for any deleted profiles.

This would mean that profiles which are culled then re-received in the
same UI session would be horribly desynced; the MSP module would see
the data in msp.chars and think it was up to date but the TRP data
would have very few fields present.

I imagine there's a solid reason behind _why_ deletion doesn't
propagate events, including but not limited to the potential of
an infinite loop, so instead we've decided to just delete the
msp.chars entries directly from within deleteProfile. The table
of mspOwners will still be emitted if it can, but the data won't
be present in msp.chars at the time of emission. This shouldn't
be a concern because event handler order is (hopefully) unspecified.
Merge pull request #284 from Ellypse/bugfix/msp-deletion-desync
Correctly clear msp.char on registry deletion
Merge pull request #285 from Ellypse/development
1.5.4 ready for launch

@Solanya Solanya merged commit 3c007ba into master Mar 15, 2019

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.