Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patches] [Use Local Devtools Files] Don't set any module as generated_remote_modules #946

Merged
merged 2 commits into from Feb 27, 2020

Conversation

@nikolowry
Copy link
Contributor

nikolowry commented Feb 21, 2020

As mentioned in #942, generating Lighthouse reports via the DevTools' Audits panel has been broken due to trying to remotely fetch audits_worker_module.js.

This patch drops all modules from generated_remote_modules, however I'm not positive if the three other modules really need to be dropped or not. -- but from scanning third_party/devtools-frontend/scripts/build/build_release_applications.py it looked like it was dropping any remote module from being bundled (disclaimer: not a Python dev). Let me know if the changes need to be revised to only drop $resources_out_dir/audits_worker/audits_worker_module.js from generated_remote_modules in third_party/devtools-frontend/src/BUILD.gn.

Sidebar: Upstream has renamed "Audits" to "Lighthouse" and the directory structure has changed https://chromium.googlesource.com/devtools/devtools-frontend/+/88fd132a05e848d2ae13da9bacff4a6ce5863a17/front_end/ -- so this patch update will be stale relatively quickly


Edit: I updated this locally in my ungoogled-chromium-archlinux build and it applied the patch successfully for 80.0.3987.106 -- didn't even think to run the validate_with_source check, will update and push whatever required changes shortly

@nikolowry nikolowry changed the title [Patches] [Use Local Devtools Files] Don't set any module as generated modules [Patches] [Use Local Devtools Files] Don't set any module as generated_remote_modules Feb 22, 2020
Copy link
Owner

Eloston left a comment

Changes LGTM, thanks!

@Eloston Eloston added the enhancement label Feb 27, 2020
@Eloston Eloston added this to the 80.x.x.x milestone Feb 27, 2020
@Eloston Eloston merged commit e0229f8 into Eloston:master Feb 27, 2020
3 checks passed
3 checks passed
code_check Task Summary
Details
validate_config Task Summary
Details
validate_with_source Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.