Permalink
Commits on Oct 1, 2013
  1. Merge pull request #10978 from NightQuest/string_concatenation

    C++11 string literal concatenation
    Aokromes committed Oct 1, 2013
  2. Whitespace between string literals and user-defined literals is now m…

    …andatory for concatenation in C++11
    NightQuest committed Oct 1, 2013
  3. Core/SAI: Properly implement the second parameter of SMART_ACTION_CAL…

    …L_TIMED_ACTIONLIST to reflect the wiki (which also makes more sense)
    Discover- committed Oct 1, 2013
  4. Tools/MeshExtractor: Implemented the code to generate mesh files for …

    …continent maps.
    
    Fixed a few more things
    ToDo:
    Test the generated navmesh.
    Subv committed Oct 1, 2013
Commits on Sep 30, 2013
  1. Tools/MeshExtractor: Fixed mmap extracting for instance maps and fixe…

    …d a number of issues.
    
    ToDo:
    Cleanup the code a bit.
    WILL NOT CURRENTLY WORK WITH TrinityCore, if you want to test it, use the --extract 32 flag of MeshExtractor.
    Subv committed Sep 30, 2013
  2. DB/Update: Return To...RP event update

    By @Foldor fixes #10886
    Kirkhammett committed Sep 30, 2013
  3. DB/SAI: Correction on waypoints for quest npc.

    Closes #10937
    FireEmerald committed with ZxBiohazardZx Sep 30, 2013
  4. DB/Loot: Fix Satchel of Helpful Goods

    Closes #10552
    Closes #10292
    dr-j committed with ZxBiohazardZx Sep 30, 2013
  5. Core/SAI: Add 'playerOnly' parameters to SMART_TARGET_CLOSEST_ENEMY a…

    …nd SMART_TARGET_CLOSEST_FRIENDLY. Wiki is updated accordingly.
    Discover- committed Sep 30, 2013
  6. Tools/MeshExtractor: Implemented mmap mesh generation for instances (…

    …They do not have ADT files, they're just a big WMO).
    
    Cleaned up some things and fixed some errors.
    ToDo:
    * Test this a bit more.
    * Cleanup the codebase for this, remove duplicated code.
    Subv committed Sep 30, 2013
  7. Tools/MeshExtractor: Fixed Doodads and WMOs in the terrain.

    Cleaned up a little.
    Subv committed Sep 30, 2013
Commits on Sep 29, 2013
  1. Tools/MeshExtractor: Fixed(??????) Doodads in the terrain.

    Semi-fixed WMOs in the terrain, they are wrongly rotated.
    P.D: HALP
    P.P.D: Entered "I don't know what i'm doing" mode.
    Subv committed Sep 29, 2013
  2. DB/SAI: Destroying the Alters

    By @untaught fixes #10841
    Kirkhammett committed Sep 29, 2013
  3. DB/SAI: Hampering their Escape

    By @untaught fixes #10780
    Kirkhammett committed Sep 29, 2013
  4. DB/Update: Plan B

    By @untaught fixes #10787
    Kirkhammett committed Sep 29, 2013
  5. DB/SAI: Finding the Source

    By @dr-j fixes #10943
    Kirkhammett committed Sep 29, 2013
  6. DB/SAI: Neltharion's Flame (12267)

    By @dr-j fixes #10965
    Kirkhammett committed Sep 29, 2013
  7. DB/SAI: Leading the Ancestors Home

    By @dr-j fixes #10783
    Kirkhammett committed Sep 29, 2013
  8. Core/RBAC: Simplify RBAC implementation

    - Drop groups (roles than can have inherited roles) and roles (set of
      permissions)
    - Permissions can now have inherited permissions (those act as roles)
    
    RBAC DB structure is now limited to four tables
    - rbac_permissions: Contains permissions and roles
    - rbac_linked_permissions: Contains the relation between permissions and
      linked permissions (those permissions that have linked permissions are
      called roles)
    - rbac_default_permissions: Contains the list of permissions to be granted
      to each security level [Added to maintain compatibility in an easy way]
    - rbac_account_permissions: Contains the list of permissions granted or
      denied for a particular account.
    
    NOTE: IF YOU ARE USING CUSTOM PERMISSIONS, ROLES OR GROUPS CHECK THE SQL
    BEFORE APPLYING...
    Spp- committed Sep 29, 2013
  9. Tools/VMAP Extractor: Fix memory issues

    Fix not-NULL terminated char buffer and uninitialized memory written to vmaps due to WMOLiquidHeader struct padding bytes left uninitialized. The padding bytes should be ignored anyway by VMAP Assembler so no re-extraction is required.
    
    Valgrind log:
     Syscall param write(buf) points to uninitialised byte(s)
      at 0x585FB50: __write_nocancel (syscall-template.S:81)
      by 0x57EE2F2: _IO_file_write@@GLIBC_2.2.5 (fileops.c:1270)
      by 0x57EE1D1: new_do_write (fileops.c:546)
      by 0x57EF904: _IO_do_write@@GLIBC_2.2.5 (fileops.c:519)
      by 0x57EEB70: _IO_file_xsputn@@GLIBC_2.2.5 (fileops.c:1341)
      by 0x57E3EC4: fwrite (iofwrite.c:43)
      by 0x41161B: WMOGroup::ConvertToVMAPGroupWmo(_IO_FILE*, WMORoot*, bool) (wmo.cpp:386)
      by 0x407FA9: ExtractSingleWmo(std::string&) (vmapexport.cpp:215)
      by 0x407B16: ExtractWmo() (vmapexport.cpp:138)
      by 0x409D50: main (vmapexport.cpp:497)
     Address 0x40398e2 is not stack'd, malloc'd or (recently) free'd
     Uninitialised value was created by a heap allocation
      at 0x4C2C7A7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
      by 0x410ADA: WMOGroup::open() (wmo.cpp:224)
      by 0x407F54: ExtractSingleWmo(std::string&) (vmapexport.cpp:208)
      by 0x407B16: ExtractWmo() (vmapexport.cpp:138)
      by 0x409D50: main (vmapexport.cpp:497)
    jackpoz committed Sep 29, 2013
  10. Tools/MeshExtractor: Fixed a lot of stuff, finally made the Doodads r…

    …ender, the WMO's have been disabled for now.
    
    ToDo:
    * Fix the doodads positions.
    * Review and re-implement some code.
    
    P.D: Help me please.
    Subv committed Sep 29, 2013
Commits on Sep 28, 2013
  1. Tools/MapExtractor: Fix string-related memory issues

    Fix not-NULL terminated char buffers and char[] to string conversion.
    
    Valgrind logs:
     Invalid read of size 1
      at 0x4C2D7D4: __GI_strlen (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
      by 0x5318BAF: std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.17)
      by 0x409471: ReadBuild(int) (System.cpp:189)
      by 0x40CEC6: main (System.cpp:1108)
      Address 0x5f851ee is 0 bytes after a block of size 94 alloc'd
      at 0x4C2C037: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
      by 0x40F63A: MPQFile::MPQFile(char const*) (mpq_libmpq.cpp:65)
      by 0x409408: ReadBuild(int) (System.cpp:182)
      by 0x40CEC6: main (System.cpp:1108)
    
     Invalid read of size 1
      at 0x57FFCAC: strtok (strtok.S:165)
      by 0x40D279: MPQArchive::GetFileListTo(std::vector<std::string, std::allocator<std::string> >&) (mpq_libmpq04.h:45)
      by 0x40C5CF: ExtractDBCFiles(int, bool) (System.cpp:1001)
      by 0x40CEF5: main (System.cpp:1110)
      Address 0x5f91e27 is 0 bytes after a block of size 44,391 alloc'd
      at 0x4C2C037: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
      by 0x40D1A5: MPQArchive::GetFileListTo(std::vector<std::string, std::allocator<std::string> >&) (mpq_libmpq04.h:30)
      by 0x40C5CF: ExtractDBCFiles(int, bool) (System.cpp:1001)
      by 0x40CEF5: main (System.cpp:1110)
    jackpoz committed Sep 28, 2013
  2. Core/Scripts: Fix uninitialized values in The Black Morass

    Valgrind log:
     Conditional jump or move depends on uninitialised value(s)
      at 0x1798C2C: npc_medivh_bm::npc_medivh_bmAI::UpdateAI(unsigned int) (the_black_morass.cpp:192)
      by 0x11AEFC0: Creature::Update(unsigned int) (Creature.cpp:542)
      by 0x12E96F8: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45)
    
     Conditional jump or move depends on uninitialised value(s)
      at 0x1798C7E: npc_medivh_bm::npc_medivh_bmAI::UpdateAI(unsigned int) (the_black_morass.cpp:200)
      by 0x11AEFC0: Creature::Update(unsigned int) (Creature.cpp:542)
      by 0x12E96F8: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45)
    
     Conditional jump or move depends on uninitialised value(s)
      at 0x1798CB0: npc_medivh_bm::npc_medivh_bmAI::UpdateAI(unsigned int) (the_black_morass.cpp:205)
      by 0x11AEFC0: Creature::Update(unsigned int) (Creature.cpp:542)
      by 0x12E96F8: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45)
    
     Conditional jump or move depends on uninitialised value(s)
      at 0x1798CE2: npc_medivh_bm::npc_medivh_bmAI::UpdateAI(unsigned int) (the_black_morass.cpp:210)
      by 0x11AEFC0: Creature::Update(unsigned int) (Creature.cpp:542)
      by 0x12E96F8: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45)
    jackpoz committed Sep 28, 2013
  3. Merge pull request #10966 from Chaplain/Mesh

    Tools/MeshExtractor: Cleanup using static analyzing tool
    Subv committed Sep 28, 2013
  4. DB/Update: Pet spells

    Kirkhammett committed Sep 28, 2013