Fixed invalid negative input#14
Closed
Benzolitz wants to merge 3 commits intoEmKayDK:bug-fixesfrom
Benzolitz:Benzolitz-patch-1
Closed
Fixed invalid negative input#14Benzolitz wants to merge 3 commits intoEmKayDK:bug-fixesfrom Benzolitz:Benzolitz-patch-1
Benzolitz wants to merge 3 commits intoEmKayDK:bug-fixesfrom
Benzolitz:Benzolitz-patch-1
Conversation
Updated tests to include this. Added Syn to the project instead of including it directly from Github.
Script only checked if input has a bigger length then maxValue. If you wanted to enter a negative Value which is longer than the maxValue, the script stoped you from doing so. Only possibility was to use the mousewheel.
Author
I can write -9, but I can't add another 9. The script will stop me because the only check is if the Value.length is bigger than maxValue.length. |
Author
|
Didn't want to close :D |
EmKayDK
added a commit
that referenced
this pull request
Sep 19, 2015
Owner
|
Fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the script only checkes if the input has a bigger length then maxValue. If you want to enter a negative Value which is longer than the maxValue, the script stops you from doing so. Only possibility was to use the mousewheel.