Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

licenses.exceptions doesn’t work with licenses.clarify #406

Closed
Jayman2000 opened this issue Feb 12, 2022 · 0 comments · Fixed by #407
Closed

licenses.exceptions doesn’t work with licenses.clarify #406

Jayman2000 opened this issue Feb 12, 2022 · 0 comments · Fixed by #407
Labels
bug Something isn't working

Comments

@Jayman2000
Copy link

Describe the bug
If you specify a crate’s license with licenses.clarify and allow that license using licenses.exceptions, then cargo deny check license will fail. Here’s a deny.toml that causes the error:

[licenses]
default = "deny"
allow-osi-fsf-free = "either"
deny = [
    "OpenSSL",
]

exceptions = [
    { allow = ["ISC", "MIT", "OpenSSL"], name = "ring" }
]

[[licenses.clarify]]
name = "ring"
expression = "ISC AND MIT AND OpenSSL"
license-files = [{ path = "LICENSE", hash = 0xbd0eed23 }]

To Reproduce

  1. Download this minimum reproduction project.
  2. Extract it and cd to its directory.
  3. Run cargo deny check license.

Expected behavior
I expected no warnings or errors.

Device:

  • OS: Arch Linux
  • Browser: N/A
  • Version: 0.11.2 (0.11.1 doesn’t have this bug)
@Jayman2000 Jayman2000 added the bug Something isn't working label Feb 12, 2022
kim pushed a commit to kim/radicle-link that referenced this issue Feb 14, 2022
This change updates cargo-deny to 0.11.1. At the moment, the latest
version is 0.11.2 [1], but we can’t use that version yet because of this
bug [2].

[1]: <https://github.com/EmbarkStudios/cargo-deny/releases>
[2]: <EmbarkStudios/cargo-deny#406>

Signed-off-by: Jason Yundt <jason@jasonyundt.email>
kim added a commit to kim/radicle-link that referenced this issue Feb 15, 2022
Since `default = "deny"`, it is not necessary to maintain an explicit
`deny` list. This is not only simpler, but also avoids hitting

    EmbarkStudios/cargo-deny#406

Also remove GPLv2 from allow list, as it's not actually compatible with
GPLv3.

Signed-off-by: Kim Altintop <kim@eagain.st>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant