-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workspace-duplicates is oversensitive for intra-workspace path-only dependencies #682
Comments
Why would it be pointless? That would mean that every dependency declaration would need to use the full relative path making it tedious to move/rename. But I'll add an option. |
At least in our workspace, the crate directories are all direct descendants of the workspace directory, so the warnings end up looking like
Except multiply that by a couple of dozen values of Sure, "maybe don't put dozens of crates as sibling directories without any kind of organizing hierarchy" would have been good advice to give several years ago when this workspace was first set up, but here we are. |
Is your feature request related to a problem? Please describe.
We have a monorepo with a large number of crates in the workspace. We use workspace dependencies for external dependencies, so we really like the
workspace-duplicates
warning, but it's a bit pedantic and arguably not even desirable when it complains aboutpath
dependencies between different crates in the workspace.Describe the solution you'd like
Do not trigger
workspace-duplicates
if all of the following are true:path
(as opposed topath
+ version or git target. This necessarily means the referencing crate cannot be published to a registry)path
is to another crate in the same workspace.publish = false
).In that situation, it is unlikely that the crate would ever be referred to by anything other than
path
, so adding an entry in the workspace-levelCargo.toml
is kind of pointless.Describe alternatives you've considered
Adding a configuration option for
workspace-duplicates
to ignorepath
-only dependencies. This would simplify the analysis above, as only the first criteria would need to be evaluated.The text was updated successfully, but these errors were encountered: