Fix erroneously pruned crates #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If _any_ license file failed the gather would fail, kind of defeating the purpose of being able to have multiple license files. The failures are now also added to the Ok if at least some expression was able to be procured, and those warnings/errors are now displayed in the diagnostic for the krate license. We also now include all of the files that were involved in synthesizing the expression for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps krates to 0.12.5 to fix an issue where the index was treated as authoritative on feature sets....overwriting valid features that were turned on, potentially causing crates to be erroneously pruned from the crate graph.
Also fixes an issue with multiple license files for a crate, where any failure would cause the license gather to fail, even if at least one license file could be successfully scored with a license. So now those failures are just appended to the diagnostic that is shown. The license file names where the license expression was gathered from are also now shown in the diagnostic.