Skip to content

Upload CSV to table #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
osipovartem merged 11 commits into from
Jan 15, 2025
Merged

Upload CSV to table #144

osipovartem merged 11 commits into from
Jan 15, 2025

Conversation

@osipovartem
Copy link
Contributor

@osipovartem osipovartem commented Jan 14, 2025 •
edited
Loading

Closes #142

  • returned back InMemory tables
  • removed forked UDFs (least, greatest)
  • fixed CSV file upload
    • register CSV file with the ctx
    • insert as select from registered CSV table
    • keep icelake code for a while since datafusion doesn't update metadata file statistics

@eadgbear
Copy link
Contributor

eadgbear commented Jan 15, 2025

LGTM

@osipovartem osipovartem merged commit 45424a0 into main Jan 15, 2025
5 checks passed
@osipovartem osipovartem deleted the issues/142-upload_csv branch January 15, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rampage644 rampage644 Awaiting requested review from rampage644

@Vedin Vedin Awaiting requested review from Vedin

@DanCodedThis DanCodedThis Awaiting requested review from DanCodedThis

1 more reviewer

@eadgbear eadgbear eadgbear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use datafusion to upload CSV file to created table

3 participants

@osipovartem @eadgbear