Preprocess ALTER ICEBERG TABLE #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rampage644
requested review from
DanCodedThis,
Vedin,
YaroslavLitvinov,
eadgbear and
osipovartem
eadgbear
approved these changes
Feb 7, 2025
DanCodedThis
approved these changes
Feb 7, 2025
Contributor
There was a problem hiding this comment.
I have no idea how did this work previously... Feel free to point me to actual broken code. Most recent main fails to process
ALTER ICEBERG TABLEby failing withParserError: Expected TABLE, VIEW, INDEX...
I also had a question how did it work without, either preprocessing or extending the parser with a statement.
Anyway, LGTM, also here is the issue for extending the parser with this statement: #196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea how did this work previously... Feel free to point me to actual broken code.
Most recent main fails to process
ALTER ICEBERG TABLEby failing withParserError: Expected TABLE, VIEW, INDEX...