-
Notifications
You must be signed in to change notification settings - Fork 5
Fix dateadd function #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dateadd function #224
Conversation
* Use interval instead of duration type for hour/minute/second * Handle empty array case
|
Vedin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine for now and I believe work pretty fast. I still don't like to create additional array for scalar values. We should consider using something similar to evaluate_array_scalar in the future.
|
@DanCodedThis Feel free to take over this (i.e. decision to merge is on you), feel free to remove all code I've written altogether. |
This is a quick fix for
dateaddUDF - it just makes it work such that its physical execution works for dbt snowplowworkload.
Ideally, it should be reimplemented differently:
ColumnarValue::Arrayas a first class citizen (whereas scalar is an exception, not otherwise)Good example is in datafusion-examples directory.
Fixes - somewhat incorrect - #223