Skip to content

Reduce redundancy in manifest #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
YaroslavLitvinov merged 1 commit into from
Feb 13, 2025
Merged

Reduce redundancy in manifest #242

YaroslavLitvinov merged 1 commit into from
Feb 13, 2025

Conversation

@YaroslavLitvinov
Copy link
Contributor

@YaroslavLitvinov YaroslavLitvinov commented Feb 13, 2025 •
edited
Loading

There are no related issue. The goal of this PR is to make manifests a bit simpler.

rampage644
rampage644 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@rampage644 rampage644 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem great to me, @slyons any objection why not pinning shared deps in the root cargo.toml?

@YaroslavLitvinov YaroslavLitvinov merged commit 1ac46bf into main Feb 13, 2025
5 checks passed
@YaroslavLitvinov YaroslavLitvinov deleted the yaroslav/reduce_manifest_redundancy branch February 13, 2025 23:00
@eadgbear
Copy link
Contributor

eadgbear commented Feb 13, 2025

Hey why did we merge this? The patching was for a reason. It's to enforce our fork of Datafusion across all dependencies.

@YaroslavLitvinov
Copy link
Contributor Author

YaroslavLitvinov commented Feb 14, 2025

Works for me:

git checkout yaroslav/reduce_manifest_redundancy
(cd crates/nexus/ && cargo test -- --exact http::dbt::error::tests::test_http_server_response)

Output:

running 1 test
test http::dbt::error::tests::test_http_server_response ... ok

@YaroslavLitvinov
Copy link
Contributor Author

YaroslavLitvinov commented Feb 14, 2025 •
edited
Loading 

git checkout 92131313047b737cedaa7fba3ef671cf901d7c32 # <- before merge
git checkout -b test_patch_crates_io
cargo tree

# vs

git checkout 1ac46bf5bf05cd46ccf18aa503a3c89578142c83 # <- after merge
cargo tree

cargo tree shows no related changes:

diff /tmp/cagro-tree.nopatch  /tmp/cagro-tree.withpatch
0a1

@YaroslavLitvinov YaroslavLitvinov mentioned this pull request Feb 14, 2025
Closed
osipovartem added a commit that referenced this pull request Feb 17, 2025
@osipovartem
Combined docker image (init)
2755b36 
Combined docker image (init)

Set variable, set entity within session (#232)

* Set variable, set entity

* Fix comments

Rename multipart field to camelCase (#238)

* Rename multipart field to camelCase

* small improvement

Refine http status codes (#237)

* fix dbt retry

* fmt

* more retries fixed

Try to get catalog name from session with fallback to default (#239)

less redundancy in manifest (#242)

Fixing CORS to allow Cookies from UI (#235)

* Fixing CORS to allow Cookies from UI

* Formatting fix

* Clippy fixes

* Adding flag to enable CORS

* Adjusting CORS arg name

Add CONTIBUTING.md draft (#240)

* Add CONTIBUTING.md draft

* Updating CONTRIBUTING and CODE_OF_CONDUCT

* Renaming

---------

Co-authored-by: Scott Lyons <scottalyons@gmail.com>

Renaming icehut -> icebucket (#244)

* Rename IceHut -> IceBucket

* Formatting fix

Adding workflow to generator a list of contributors (#246)

Updating README structure with new name (#245)

* Initial README restructuring

* Update README.md (#234)

* Updating README with new name

* Adding LICENSE file

* Fixing LICENSE

---------

Co-authored-by: DanCodedThis <94703934+DanCodedThis@users.noreply.github.com>

Changing contributor script (#248)

* Adding workflow to generator a list of contributors

* Changing contributor script

Make SP endpoint optional (#250)

Tmp tyr to build

Dockerfile update

Add file system storage profile

Add file system storage profile
osipovartem added a commit that referenced this pull request Feb 17, 2025
@osipovartem
Added FS storage profile (#263)
9b7a65b 
* Combined docker image (init)

Combined docker image (init)

Set variable, set entity within session (#232)

* Set variable, set entity

* Fix comments

Rename multipart field to camelCase (#238)

* Rename multipart field to camelCase

* small improvement

Refine http status codes (#237)

* fix dbt retry

* fmt

* more retries fixed

Try to get catalog name from session with fallback to default (#239)

less redundancy in manifest (#242)

Fixing CORS to allow Cookies from UI (#235)

* Fixing CORS to allow Cookies from UI

* Formatting fix

* Clippy fixes

* Adding flag to enable CORS

* Adjusting CORS arg name

Add CONTIBUTING.md draft (#240)

* Add CONTIBUTING.md draft

* Updating CONTRIBUTING and CODE_OF_CONDUCT

* Renaming

---------

Co-authored-by: Scott Lyons <scottalyons@gmail.com>

Renaming icehut -> icebucket (#244)

* Rename IceHut -> IceBucket

* Formatting fix

Adding workflow to generator a list of contributors (#246)

Updating README structure with new name (#245)

* Initial README restructuring

* Update README.md (#234)

* Updating README with new name

* Adding LICENSE file

* Fixing LICENSE

---------

Co-authored-by: DanCodedThis <94703934+DanCodedThis@users.noreply.github.com>

Changing contributor script (#248)

* Adding workflow to generator a list of contributors

* Changing contributor script

Make SP endpoint optional (#250)

Tmp tyr to build

Dockerfile update

Add file system storage profile

Add file system storage profile

* Merge
osipovartem added a commit that referenced this pull request Feb 17, 2025
@osipovartem
Add more catalog tests (#265)
5699180 
* Combined docker image (init)

Combined docker image (init)

Set variable, set entity within session (#232)

* Set variable, set entity

* Fix comments

Rename multipart field to camelCase (#238)

* Rename multipart field to camelCase

* small improvement

Refine http status codes (#237)

* fix dbt retry

* fmt

* more retries fixed

Try to get catalog name from session with fallback to default (#239)

less redundancy in manifest (#242)

Fixing CORS to allow Cookies from UI (#235)

* Fixing CORS to allow Cookies from UI

* Formatting fix

* Clippy fixes

* Adding flag to enable CORS

* Adjusting CORS arg name

Add CONTIBUTING.md draft (#240)

* Add CONTIBUTING.md draft

* Updating CONTRIBUTING and CODE_OF_CONDUCT

* Renaming

---------

Co-authored-by: Scott Lyons <scottalyons@gmail.com>

Renaming icehut -> icebucket (#244)

* Rename IceHut -> IceBucket

* Formatting fix

Adding workflow to generator a list of contributors (#246)

Updating README structure with new name (#245)

* Initial README restructuring

* Update README.md (#234)

* Updating README with new name

* Adding LICENSE file

* Fixing LICENSE

---------

Co-authored-by: DanCodedThis <94703934+DanCodedThis@users.noreply.github.com>

Changing contributor script (#248)

* Adding workflow to generator a list of contributors

* Changing contributor script

Make SP endpoint optional (#250)

Tmp tyr to build

Dockerfile update

Add file system storage profile

Add file system storage profile

* Merge

* Add more catalog tests

* Add more catalog tests

* Add more catalog tests
osipovartem added a commit that referenced this pull request Feb 18, 2025
@osipovartem
Control plane tests (batch 1) (#266)
15b9674 
* Combined docker image (init)

Combined docker image (init)

Set variable, set entity within session (#232)

* Set variable, set entity

* Fix comments

Rename multipart field to camelCase (#238)

* Rename multipart field to camelCase

* small improvement

Refine http status codes (#237)

* fix dbt retry

* fmt

* more retries fixed

Try to get catalog name from session with fallback to default (#239)

less redundancy in manifest (#242)

Fixing CORS to allow Cookies from UI (#235)

* Fixing CORS to allow Cookies from UI

* Formatting fix

* Clippy fixes

* Adding flag to enable CORS

* Adjusting CORS arg name

Add CONTIBUTING.md draft (#240)

* Add CONTIBUTING.md draft

* Updating CONTRIBUTING and CODE_OF_CONDUCT

* Renaming

---------

Co-authored-by: Scott Lyons <scottalyons@gmail.com>

Renaming icehut -> icebucket (#244)

* Rename IceHut -> IceBucket

* Formatting fix

Adding workflow to generator a list of contributors (#246)

Updating README structure with new name (#245)

* Initial README restructuring

* Update README.md (#234)

* Updating README with new name

* Adding LICENSE file

* Fixing LICENSE

---------

Co-authored-by: DanCodedThis <94703934+DanCodedThis@users.noreply.github.com>

Changing contributor script (#248)

* Adding workflow to generator a list of contributors

* Changing contributor script

Make SP endpoint optional (#250)

Tmp tyr to build

Dockerfile update

Add file system storage profile

Add file system storage profile

* Merge

* Add more catalog tests

* Add more catalog tests

* Add more catalog tests

* CP tests batch

* Fix invlalid region error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rampage644 rampage644 rampage644 approved these changes

@eadgbear eadgbear Awaiting requested review from eadgbear

@Vedin Vedin Awaiting requested review from Vedin

@osipovartem osipovartem Awaiting requested review from osipovartem

@DanCodedThis DanCodedThis Awaiting requested review from DanCodedThis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YaroslavLitvinov @eadgbear @rampage644