Control plane tests (batch 1) #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combined docker image (init) Set variable, set entity within session (#232) * Set variable, set entity * Fix comments Rename multipart field to camelCase (#238) * Rename multipart field to camelCase * small improvement Refine http status codes (#237) * fix dbt retry * fmt * more retries fixed Try to get catalog name from session with fallback to default (#239) less redundancy in manifest (#242) Fixing CORS to allow Cookies from UI (#235) * Fixing CORS to allow Cookies from UI * Formatting fix * Clippy fixes * Adding flag to enable CORS * Adjusting CORS arg name Add CONTIBUTING.md draft (#240) * Add CONTIBUTING.md draft * Updating CONTRIBUTING and CODE_OF_CONDUCT * Renaming --------- Co-authored-by: Scott Lyons <scottalyons@gmail.com> Renaming icehut -> icebucket (#244) * Rename IceHut -> IceBucket * Formatting fix Adding workflow to generator a list of contributors (#246) Updating README structure with new name (#245) * Initial README restructuring * Update README.md (#234) * Updating README with new name * Adding LICENSE file * Fixing LICENSE --------- Co-authored-by: DanCodedThis <94703934+DanCodedThis@users.noreply.github.com> Changing contributor script (#248) * Adding workflow to generator a list of contributors * Changing contributor script Make SP endpoint optional (#250) Tmp tyr to build Dockerfile update Add file system storage profile Add file system storage profile
osipovartem
requested review from
DanCodedThis,
Vedin,
YaroslavLitvinov and
rampage644
rampage644
reviewed
Feb 18, 2025
| return Err(ControlPlaneModelError::InvalidBucketName { | ||
| bucket_name: String::new(), | ||
| reason: "Bucket name is required".to_owned(), | ||
| reason: "Region name is required".to_owned(), |
Contributor
There was a problem hiding this comment.
ControlPlaneModelError::InvalidBucketName -> ControlPlaneModelError::InvalidRegion?
rampage644
approved these changes
Feb 18, 2025
osipovartem
temporarily deployed
to
production
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #264