Skip to content

service: Read only mode add show statements #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanCodedThis merged 2 commits into from
Nov 24, 2025
Merged

service: Read only mode add show statements #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33f8e02
Add support for read only mode show statements
DanCodedThis Nov 24, 2025
3a0f3d8
Add support for read only mode show statements test fix
DanCodedThis Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion crates/executor/src/query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,15 @@ impl UserQuery {
Statement::Use(entity) => {
return self.execute_use_statement(entity).await;
}
Statement::ShowDatabases { .. }
| Statement::ShowSchemas { .. }
| Statement::ShowTables { .. }
| Statement::ShowColumns { .. }
| Statement::ShowViews { .. }
| Statement::ShowFunctions { .. }
| Statement::ShowObjects { .. }
| Statement::ShowVariables { .. }
| Statement::ShowVariable { .. } => return Box::pin(self.show_query(*s)).await,
other => {
return ex_error::NotSupportedStatementInReadOnlyModeSnafu {
statement: other.to_string(),
Expand All @@ -297,7 +306,17 @@ impl UserQuery {
},
DFStatement::Explain(explain) => match *explain.statement {
DFStatement::Statement(s) => match *s {
Statement::Query(..) | Statement::Use(..) => {
Statement::Query(..)
| Statement::Use(..)
| Statement::ShowDatabases { .. }
| Statement::ShowSchemas { .. }
| Statement::ShowTables { .. }
| Statement::ShowColumns { .. }
| Statement::ShowViews { .. }
| Statement::ShowFunctions { .. }
| Statement::ShowObjects { .. }
| Statement::ShowVariables { .. }
| Statement::ShowVariable { .. } => {
return self.execute_sql(&self.query).await;
}
other => {
Expand Down
19 changes: 19 additions & 0 deletions crates/executor/src/tests/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,4 +562,23 @@ async fn test_execute_read_only_mode() {
)
.await
.expect("Failed to execute query in read only mode");

execution_svc
.query("test_session_id", "SHOW TABLES;", QueryContext::default())
.await
.expect("Failed to execute query in read only mode");

execution_svc
.query("test_session_id", "SHOW SCHEMAS;", QueryContext::default())
.await
.expect("Failed to execute query in read only mode");

execution_svc
.query(
"test_session_id",
"SHOW DATABASES;",
QueryContext::default(),
)
.await
.expect("Failed to execute query in read only mode");
}