Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Handle url and descriptions from campfire #14

Merged
merged 1 commit into from

2 participants

@katzj

Campfire API seems to send url and description with some sounds
now leading to messages like

2013-03-07 23:51:28 48012 WARN CamperVan : WARNING: Could not set attribute 'url' to value 'https://123.campfirenow.com/sounds/crickets.mp3' on Firering::Message object. It is likely the Campfire API has changed. Please report this! (https://github.com/EmmanuelOga/firering/issues)
2013-03-07 23:51:28 48012 WARN CamperVan : WARNING: Could not set attribute 'description' to value 'hears crickets chirping' on Firering::Message object. It is likely the Campfire API has changed. Please report this! (https://github.com/EmmanuelOga/firering/issues)

@katzj katzj Handle url and descriptions from campfire
Campfire API seems to send url and description with some sounds
now leading to messages like

2013-03-07 23:51:28 48012  WARN CamperVan : WARNING: Could not set attribute 'url' to value 'https://123.campfirenow.com/sounds/crickets.mp3'; on Firering::Message object. It is likely the Campfire API has changed. Please report this! (https://github.com/EmmanuelOga/firering/issues)
2013-03-07 23:51:28 48012  WARN CamperVan : WARNING: Could not set attribute 'description' to value 'hears crickets chirping' on Firering::Message object. It is likely the Campfire API has changed. Please report this! (https://github.com/EmmanuelOga/firering/issues)

This should fix
ee96bf8
@indirect
Collaborator

Thanks!

@indirect indirect merged commit 8938f01 into EmmanuelOga:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 8, 2013
  1. @katzj

    Handle url and descriptions from campfire

    katzj authored
    Campfire API seems to send url and description with some sounds
    now leading to messages like
    
    2013-03-07 23:51:28 48012  WARN CamperVan : WARNING: Could not set attribute 'url' to value 'https://123.campfirenow.com/sounds/crickets.mp3'; on Firering::Message object. It is likely the Campfire API has changed. Please report this! (https://github.com/EmmanuelOga/firering/issues)
    2013-03-07 23:51:28 48012  WARN CamperVan : WARNING: Could not set attribute 'description' to value 'hears crickets chirping' on Firering::Message object. It is likely the Campfire API has changed. Please report this! (https://github.com/EmmanuelOga/firering/issues)
    
    This should fix
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/firering/data/message.rb
View
2  lib/firering/data/message.rb
@@ -1,5 +1,5 @@
module Firering
- Message = Struct.new(:connection, :id, :room_id, :user_id, :body, :created_at, :type, :starred, :tweet)
+ Message = Struct.new(:connection, :id, :room_id, :user_id, :body, :created_at, :type, :starred, :tweet, :url, :description)
class Message
extend Instantiator
Something went wrong with that request. Please try again.