New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect os in build.gradle, add error reportrer #181

Merged
merged 3 commits into from Aug 16, 2018

Conversation

Projects
None yet
2 participants
@ice1000
Member

ice1000 commented Aug 16, 2018

No description provided.

@ice1000 ice1000 added the enhancement label Aug 16, 2018

@ice1000 ice1000 self-assigned this Aug 16, 2018

@ice1000 ice1000 requested a review from tangzx Aug 16, 2018

private object AnonymousFeedback {
private const val tokenFile = "de/halirutan/mathematica/errorreporting-emmylua/token.bin"
private const val gitRepoUser = "EmmyLua"
private const val gitRepo = "IntelliJ-EmmyLua"

This comment has been minimized.

@ice1000

ice1000 Aug 16, 2018

Member

@tangzx Change repo user and name

"error.hash" to error.exceptionHash)
for (attachment in error.attachments) {
params["attachment.name"] = attachment.name
params["attachment.value"] = attachment.encodedBytes

This comment has been minimized.

@tangzx

tangzx Aug 16, 2018

Collaborator

循环里值会被覆盖,这个没问题?

This comment has been minimized.

@ice1000

ice1000 Aug 16, 2018

Member

卧槽。我写的时候还没注意到,我改一下吧

This comment has been minimized.

@ice1000

ice1000 Aug 16, 2018

Member

我已经在最后的版本里面改了

@ice1000 ice1000 merged commit e60991d into EmmyLua:master Aug 16, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ice1000

This comment has been minimized.

Member

ice1000 commented Aug 16, 2018

我错了,我本地不小心push到origin了。。

val params = mutableMapOf(
"error.description" to error.description,
// TODO
// "Lua Version" to (project?.run { /* get lua sdk version here */ } ?: "Unknown"),

This comment has been minimized.

@ice1000

ice1000 Aug 16, 2018

Member

阿唐你看要不要在这里加点获取当前信息的代码 @tangzx

This comment has been minimized.

@tangzx

tangzx Aug 17, 2018

Collaborator

就这样吧,我看已经很OK了

This comment has been minimized.

@ice1000

ice1000 Aug 17, 2018

Member

我觉得可以把Lua的SDK信息也放进来啊,这样你好调试什么的

This comment has been minimized.

@ice1000

ice1000 Aug 17, 2018

Member

真的,不然很无语的

This comment has been minimized.

@tangzx

tangzx Aug 17, 2018

Collaborator

那个SDK是假的,暂时没作用

This comment has been minimized.

@ice1000

ice1000 Aug 17, 2018

Member

。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment