(rebase) Namespace writing - resolves #52 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empact
reviewed
Nov 17, 2017
spec/xml/namespace_spec.rb
Outdated
| output.root = VApp.from_xml(@xml).to_xml | ||
| pending "Full namespace write support" | ||
| output.should == ROXML::XML.parse_string(@xml) | ||
| namespaces = {'vmw' => "http://foo.example.com", 'gronk' => "http://gronk.example.com"} |
Empact
reviewed
Nov 17, 2017
lib/roxml.rb
Outdated
| @@ -42,6 +42,7 @@ def to_xml(params = {}) | |||
| ref.update_xml(root, value) | |||
| end | |||
| end | |||
| params[:namespaces].each { |prefix, url| root.add_namespace_definition(prefix, url) } if params[:namespaces] | |||
There was a problem hiding this comment.
Could you shorten this line? It looks on the long side...
|
Good catches - thanks for the review |
|
It turns out there was a logical issue in #32 - which caused empty elements without a default to get skipped in the output unless they had a default. I added a failing test of this, confirm that test passed prior to #32, then updated the code added on #32 to make it pass again. Somehow I made a mess of the commit history, I will try to sort that out so it's cleaner to merge |
lostapathy
force-pushed
the
namespace_writing
branch
from
edcb188
to
4b68962
Compare
|
Sorry for the noise - I reset my branch, rebased and reapplied the commits and I think this is ready to look at now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rebases #52 to add support for writing namespaces.
Like the original requester I'm open to feedback on this, I just wanted to get that PR updated and ready to either merge, ready for feedback on what else to do, or else reject the whole idea.