Fix schema.rb generation for Rails 4.x #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In versions 4.x, when updating the schema.rb file, Rails includes any view in the DB in the list "create_table" statements. When scenic adds the corresponding "create_view" statements, they fail because of the duplicate names. This is due to MySQL including views in the output of "show tables" and Rails not filtering them out. This code patches the schema dumper on old Rails versios to prevent outputting views as if they were tables.
|
Looks good! Thanks @josepegea |
|
available in v1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In versions 4.x, when updating the schema.rb file, Rails includes any
view in the DB in the list "create_table" statements.
When scenic adds the corresponding "create_view" statements, they fail
because of the duplicate names.
This is due to MySQL including views in the output of "show tables"
and Rails not filtering them out.
This code patches the schema dumper on old Rails versios to prevent
outputting views as if they were tables.
This should fix #2