Python Agent: Emoji in command responses breaks the agent

[Viss]

Empire Version

newest out of dev, 6/22/17

OS Information (Linux flavor, Python version)

server ubuntu, target newest macos

Expected behavior and description of the error, including any actions taken immediately prior to the error. The more detail the better.

On a live engagement I encountered a machine which had a single emoji character as its hostname. This broke empire, and agents would fail to connect from this host. The following error messages were displayed:

[rvrsh3ll]

lol, will look into this for sure. If you have a fix, PR please!

[killswitch-GUI]

this is a unicode issue. I have a parser for this! Will take a look

[killswitch-GUI]

Can not replicate @Viss

Please provide some more info or maybe you can replicate. At the moment it seems like the unicode parsing is correctly working. Are you sure it was in the hostname?

[Viss]

Ah, I should have specified.
The victim in this case was a mac.
and the shell was python.

I guess this is a non issue on windows boxes with powershell agents.
Python though, starts fires :D

[killswitch-GUI]

@Viss ahh ok ty for update will check it out!

[killswitch-GUI]

@Viss pull request open!

[rvrsh3ll]

Merged into Dev @Viss

[jeffmcjunkin]

For posterity: 🍌 4eva