Skip to content
Permalink
Browse files

upgrade docker to node 10

  • Loading branch information...
SebastienGllmt committed Oct 10, 2019
1 parent 4fda323 commit 4559341cf215298465ea089c715c2acb3176ecbc
@@ -2,7 +2,7 @@

Execute from git repo root:
```
docker build --target circleci-node-8-browsers emurgornd/circleci-node-8-browsers
docker build --target firefox-dev -t emurgornd/circleci-node-8-browsers:firefox-dev .
docker build --target brave -t emurgornd/circleci-node-8-browsers:brave .
docker build --target circleci-node-10-browsers -t emurgornd/circleci-node-10-browsers .
docker build --target firefox-dev -t emurgornd/circleci-node-10-browsers:firefox-dev .
docker build --target brave -t emurgornd/circleci-node-10-browsers:brave .
```
@@ -66,7 +66,7 @@ jobs:
POC: poc
working_directory: ~/repo
docker:
- image: circleci/node:8-browsers
- image: circleci/node:10-browsers

steps:
- checkout
@@ -135,7 +135,7 @@ jobs:
BROWSER: brave
working_directory: ~/repo
docker:
- image: emurgornd/circleci-node-8-browsers:brave
- image: emurgornd/circleci-node-10-browsers:brave

steps:
- *attach_workspace
@@ -151,7 +151,7 @@ jobs:
BROWSER: chrome
working_directory: ~/repo
docker:
- image: circleci/node:8-browsers
- image: circleci/node:10-browsers

steps:
- *attach_workspace
@@ -170,7 +170,7 @@ jobs:
# unsiggned addons are only supported in Firefox-dev, Firefox nightly and Firefox-esr
# CircleCI comes w/ Firefox but we need to replace it w/ Firefox-esr,
# so we use a custom image derivated from circleci's one:
- image: emurgornd/circleci-node-8-browsers:firefox-dev
- image: emurgornd/circleci-node-10-browsers:firefox-dev

steps:
- *attach_workspace
@@ -185,7 +185,7 @@ jobs:
<<: *global_environment
working_directory: ~/repo
docker:
- image: circleci/node:8-browsers
- image: circleci/node:10-browsers

steps:
- *attach_workspace
@@ -204,7 +204,7 @@ jobs:
<<: *global_environment
working_directory: ~/repo
docker:
- image: circleci/node:8-browsers
- image: circleci/node:10-browsers
steps:
- *attach_workspace
- run: echo $RUN_EXTRA_TESTS
@@ -16,7 +16,6 @@ import { ROUTES } from '../../routes-config';
import config from '../../config';

import { formattedWalletAmount } from '../../utils/formatters';
import type { PublicDeriverWithCachedMeta } from '../../stores/base/WalletStore';

@observer
export default class DaedalusTransferPage extends Component<InjectedProps> {
@@ -72,7 +72,7 @@ export default class WalletReceivePage extends Component<Props, State> {

// Guard against potential null values
if (!publicDeriver) throw new Error('Active wallet required for WalletReceivePage.');

// assume account-level wallet for now
const withChains = asHasChains(publicDeriver.self);
if (!withChains) throw new Error('WalletReceivePage only available for account-level wallets');
@@ -25,7 +25,7 @@ Sometimes it is useful and faster to simulate running our CI on your local machi
#### Updating image

You sometimes need to update your docker image (for example get the latest version of browsers). This requires you to delete your existing image and recreate a new one
1) `docker pull -a emurgornd/circleci-node-8-browsers`
1) `docker pull -a emurgornd/circleci-node-10-browsers`
1) `docker stop yoroi_ci`
1) `docker rm yoroi_ci`
1) See instructions for setting up LocalCI for the first time
@@ -2,7 +2,7 @@

# install same base as our CI build
# TODO: make this use emurgornd once the emurgornd image auto-updates to latest chromedriver
sudo docker run --name yoroi_ci -p 5900:5900 -dit circleci/node:8-browsers
sudo docker run --name yoroi_ci -p 5900:5900 -dit circleci/node:10-browsers

sudo docker cp features/localCI/. yoroi_ci:/CI
user=$(sudo docker exec -t yoroi_ci whoami | tr -d '\r')

0 comments on commit 4559341

Please sign in to comment.
You can’t perform that action at this time.