From 69f92957e3e974b4f24e07bbb2a4f39961139d64 Mon Sep 17 00:00:00 2001 From: Paul Ccari Date: Fri, 24 Sep 2021 03:52:35 -0500 Subject: [PATCH] small fixes --- .../transfer/TransferSummaryPage.js | 2 +- .../widgets/DangerousActionDialog.js | 22 ++++--------------- .../app/styles/overrides/Button.js | 2 ++ .../app/styles/themes/modern-theme.js | 2 +- 4 files changed, 8 insertions(+), 20 deletions(-) diff --git a/packages/yoroi-extension/app/components/transfer/TransferSummaryPage.js b/packages/yoroi-extension/app/components/transfer/TransferSummaryPage.js index 9062bafc90..6a929b3f30 100644 --- a/packages/yoroi-extension/app/components/transfer/TransferSummaryPage.js +++ b/packages/yoroi-extension/app/components/transfer/TransferSummaryPage.js @@ -103,7 +103,7 @@ export default class TransferSummaryPage extends Component { ]; return ( } diff --git a/packages/yoroi-extension/app/components/widgets/DangerousActionDialog.js b/packages/yoroi-extension/app/components/widgets/DangerousActionDialog.js index 353e3179a2..1f294ca093 100644 --- a/packages/yoroi-extension/app/components/widgets/DangerousActionDialog.js +++ b/packages/yoroi-extension/app/components/widgets/DangerousActionDialog.js @@ -10,7 +10,6 @@ import globalMessages from '../../i18n/global-messages'; import LocalizableError from '../../i18n/LocalizableError'; import CheckboxLabel from '../common/CheckboxLabel'; import styles from './DangerousActionDialog.scss'; -import dangerousButtonStyles from '../../themes/overrides/DangerousButton.scss'; import type { $npm$ReactIntl$IntlFormat } from 'react-intl'; type Props = {| @@ -35,16 +34,13 @@ type Props = {| @observer export default class DangerousActionDialog extends Component { - static contextTypes: {|intl: $npm$ReactIntl$IntlFormat|} = { + static contextTypes: {| intl: $npm$ReactIntl$IntlFormat |} = { intl: intlShape.isRequired, }; render(): Node { const { intl } = this.context; - const { - isSubmitting, - error, - } = this.props; + const { isSubmitting, error } = this.props; const dialogClasses = classnames(['removeWalletDialog', styles.dialog]); @@ -65,7 +61,7 @@ export default class DangerousActionDialog extends Component { primary: true, className: confirmButtonClasses, disabled: !this.props.isChecked ? true : undefined, - themeOverrides: dangerousButtonStyles, + danger: true, isSubmitting: this.props.isSubmitting, ...(this.props.primaryButton ?? Object.freeze({})), }, @@ -80,7 +76,6 @@ export default class DangerousActionDialog extends Component { className={dialogClasses} closeButton={} > - {this.props.children}
@@ -91,17 +86,8 @@ export default class DangerousActionDialog extends Component { />
- {error - ? ( -

- {intl.formatMessage(error, error.values)} -

- ) - : null - } - + {error ?

{intl.formatMessage(error, error.values)}

: null}
); } - } diff --git a/packages/yoroi-extension/app/styles/overrides/Button.js b/packages/yoroi-extension/app/styles/overrides/Button.js index c8e98ef50b..c28c4e4954 100644 --- a/packages/yoroi-extension/app/styles/overrides/Button.js +++ b/packages/yoroi-extension/app/styles/overrides/Button.js @@ -70,6 +70,7 @@ const ClassicButton = { }, '&.Mui-disabled': { backgroundColor: 'var(--mui-danger-button-background-color-disabled)', + color: 'white', }, '& .MuiLoadingButton-loadingIndicator': { color: 'var(--mui-danger-button-background-color)', @@ -155,6 +156,7 @@ const ModernButton = { }, '&.Mui-disabled': { backgroundColor: 'var(--mui-danger-button-background-color-disabled)', + color: 'white', }, '& .MuiLoadingButton-loadingIndicator': { color: 'var(--mui-danger-button-background-color)', diff --git a/packages/yoroi-extension/app/styles/themes/modern-theme.js b/packages/yoroi-extension/app/styles/themes/modern-theme.js index c25a4a9878..383cfd88a2 100644 --- a/packages/yoroi-extension/app/styles/themes/modern-theme.js +++ b/packages/yoroi-extension/app/styles/themes/modern-theme.js @@ -78,6 +78,6 @@ export const modernTheme: Object = createTheme({ tooltip: { fontWeight: 400, fontSize: '0.75rem', - } + }, }, });