Added a MembershipOnBoardingResolver #221

Open
wants to merge 3 commits into
from

Projects

None yet

4 participants

@HeahDude
Contributor
HeahDude commented Feb 3, 2017

No description provided.

@HeahDude HeahDude self-assigned this Feb 3, 2017
@HeahDude HeahDude requested review from hhamon, tgalopin, and romain-pierre Feb 3, 2017
@tgalopin

This PR is really great, thanks for the awesome work :) ! Besides the small comment, +1 for me.

yield ['centre-interets'];
yield ['choisir-des-comites'];
}
+ /*
+ * donate action cannot be tested because the address is filled in javascript
@tgalopin
tgalopin Feb 3, 2017 Contributor

Couldn't you use the city identifier to test without JS?

+/**
+ * A simple instance to store a registered adherent not yet activated.
+ */
+final class RegisteringAdherent implements MembershipOnBoardingInterface
@hhamon
hhamon Feb 3, 2017 Contributor

The class name seems weird to me.

@HeahDude
HeahDude Feb 4, 2017 Contributor

Fixed in 3725457.

+/**
+ * A simple instance to store a donation while on boarding.
+ */
+final class RegisteringDonation implements MembershipOnBoardingInterface
@hhamon
hhamon Feb 3, 2017 Contributor

Same here.

->add('pass', SubmitType::class)
->add('submit', SubmitType::class)
;
if ($form->handleRequest($request)->isSubmitted()) {
if ($form->get('submit')->isClicked() && $form->isValid()) {
- $manager->flush();
+ $this->getDoctrine()->getManager()->flush();
@lyrixx
lyrixx Feb 3, 2017

$this->get('doctrine.orm.default_entity_manager') and because it's too long create an alias em

HeahDude added some commits Feb 3, 2017
@HeahDude HeahDude Added a MembershipOnBoardingResolver 936062c
@HeahDude HeahDude fixup 904d8fc
@HeahDude HeahDude fixup removing session as service
446ac57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment