Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema support is disabled in Connect #75

Closed
jpechane opened this issue Nov 1, 2017 · 4 comments · Fixed by #77
Closed

Schema support is disabled in Connect #75

jpechane opened this issue Nov 1, 2017 · 4 comments · Fixed by #77
Assignees
Milestone

Comments

@jpechane
Copy link
Contributor

jpechane commented Nov 1, 2017

Connect image by default disables schema support - https://github.com/EnMasseProject/barnabas/blob/d281eb9c2ec89d0db999ea77cd2298b707cc14d6/kafka-connect/scripts/kafka_connect_run.sh#L52-L53

It should be possible to override the setting. Also it is probably better solution to have schemas enabled by default.

@scholzj
Copy link
Member

scholzj commented Nov 1, 2017

@jpechane Two questions ...

  1. I don't remeber it exactly and would need to try it out. But I believe that when I simply set it to true it will require also some other parameters to be specified. Can I really just set this to true and not change anything else?
  2. What about internal.key.converter.schemas.enable and internal.value.converter.schemas.enable?

@scholzj scholzj self-assigned this Nov 1, 2017
@jpechane
Copy link
Contributor Author

jpechane commented Nov 1, 2017

  1. It should just work. Only when Avro serializers are used then schema registry has to be provided.
  2. The are almost never changed so you can keep them as is.

scholzj added a commit to scholzj/strimzi-kafka-operator that referenced this issue Nov 1, 2017
@scholzj
Copy link
Member

scholzj commented Nov 1, 2017

@jpechane Yeah, it seems you are right. It probably matters only once some connector is deployed.

@gunnarmorling
Copy link
Contributor

Sweet, thanks for the quick fix, @scholzj!

@scholzj scholzj added this to the 0.1.0 milestone Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants