New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Tailor from moving default customizer settings #73

Closed
BinaryMoon opened this Issue Nov 13, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@BinaryMoon
Contributor

BinaryMoon commented Nov 13, 2016

It looks like Tailor is moving the header and background colour properties from the default WordPress customizer position into the Tailor menu.

I don't think this should be done for a number of reasons.

  1. It means that the settings are not where users expect them (it took me about 10 minutes of searching to find it)
  2. It breaks plugins that hook into the colours panel - including my own plugin, Styleguide - https://wordpress.org/plugins/styleguide/ - and I'm sure there are more
  3. It's not actually a Tailor setting, it's a WordPress setting.

I can see the appeal of having the all of the colours kept together, but I don't think it's logical/ expected - but the biggest argument against is that it can break plugins.

@andrew-worsfold

This comment has been minimized.

Show comment
Hide comment
@andrew-worsfold

andrew-worsfold Nov 15, 2016

Contributor

Good point. I've updated the Customizer section IDs to be more specific (e.g., tailor_colors). This will address the problem and will be included in the next release.

Contributor

andrew-worsfold commented Nov 15, 2016

Good point. I've updated the Customizer section IDs to be more specific (e.g., tailor_colors). This will address the problem and will be included in the next release.

@andrew-worsfold andrew-worsfold added the bug label Nov 15, 2016

@andrew-worsfold andrew-worsfold self-assigned this Nov 15, 2016

andrew-worsfold referenced this issue Nov 27, 2016

Tailor 1.7.6.
* Added - Element label when hovering over an element in the preview window.
* Improved - Columns now use percentage widths, instead of a 12 column grid system.
* Improved - Up to six columns can now be added to a single row instead of four (and of course you can still nest rows).
* Improved - Background image parallax effect [GitHub 60](https://github.com/andrew-worsfold/tailor/issues/60).
* Improved - Dynamic element CSS rules now supports SCSS-like syntax (e.g., :, :: and & special characters);
* Fixed - General color settings appear in the Tailor colors Customizer section for some themes [GitHub 73](https://github.com/andrew-worsfold/tailor/issues/73).
* Fixed - An error message is displayed if get_current_screen() is not defined [GitHub PR 74](https://github.com/andrew-worsfold/tailor/pull/74).
* Fixed - Elements are loaded too early, causing an issue with the New User Approve plugin [GitHub 75](https://github.com/andrew-worsfold/tailor/issues/75).
* Fixed - Graphic color not being displayed correctly when upgrading from early versions of Tailor.
* Fixed - Some units (for example "vw" and "vh" when setting minimum width and height) not being accepted in preview.
* Fixed - Masonry-enabled elements do not refresh when their parent element changes.
* Removed - Maximum 75rem width (CSS property) for Section content (use maximum width setting instead, if required).
@andrew-worsfold

This comment has been minimized.

Show comment
Hide comment
@andrew-worsfold

andrew-worsfold Nov 27, 2016

Contributor

@BinaryMoon -

This has been resolved in the latest commit. I've created more specific panel and section names for the Tailor controls to avoid conflicts with themes and other plugins. Could you please confirm that the controls are now displaying in the correct place in your theme?

Thanks for bringing this to my attention!

Contributor

andrew-worsfold commented Nov 27, 2016

@BinaryMoon -

This has been resolved in the latest commit. I've created more specific panel and section names for the Tailor controls to avoid conflicts with themes and other plugins. Could you please confirm that the controls are now displaying in the correct place in your theme?

Thanks for bringing this to my attention!

@BinaryMoon

This comment has been minimized.

Show comment
Hide comment
@BinaryMoon

BinaryMoon Nov 27, 2016

Contributor

All fixed - thank you! :)

Contributor

BinaryMoon commented Nov 27, 2016

All fixed - thank you! :)

@BinaryMoon BinaryMoon closed this Nov 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment