Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Autoplay Speed" field to Slick Slider-based elements #87

Merged
merged 3 commits into from Jan 30, 2017

Conversation

@gnowland
Copy link
Contributor

commented Jan 11, 2017

Hi Andrew,

I’ve added an input field to adjust the slide "pause" duration for all Slick Slider-based elements:

  • Carousel
  • Gallery (Carousel and Slideshow layout)
  • Posts (Carousel layout)

“Autoplay Speed” field is displayed conditionally when "Autoplay" is set to on. "Autoplay Speed" is in milliseconds.

I wasn’t sure what your preferred PR process was because I couldn’t find any contributing guidelines, so I only committed un-compiled (src) files… if you need anything else let me know.

Great project, very clean codebase — I hope to commit more in the future! 🙂

gnowland added 2 commits Jan 11, 2017
…ements

Added “Autoplay Speed” field to all Slick Slider-based elements:
    - Carousel
    - Gallery (Carousel and Slideshow layout)
    - Posts (Carousel layout)

“Autoplay Speed” field is displayed conditionally when “Autoplay” is
set to “on”.

“Autoplay Speed” is in milliseconds.
@gnowland

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2017

Came across a possible bug in production where when Tailoring the page (Customizer) the slide speed is set as undefined (0ms), investigating further.

@gnowland

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2017

Fixed the issue. 🤦‍♂️

@andrew-worsfold andrew-worsfold merged commit 298bede into Enclavely:master Jan 30, 2017
@andrew-worsfold

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2017

Thanks for the effort here, @gnowland! Much appreciated!

@gnowland

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2017

Glad to help @andrew-worsfold -- fantastic plugin, I hope to contribute more pull requests in the future!

andrew-worsfold referenced this pull request Mar 16, 2017
* Added - Instant undo/redo functionality with keyboard controls.
* Added - Portuguese translation [GitHub 93](https://github.com/andrew-worsfold/tailor/pull/93).
* Added - Autoplay speed setting to carousel and slideshow-based layouts [GitHub 87](https://github.com/andrew-worsfold/tailor/pull/87).
* Improved - Allow unlimited images in Gallery elements [GitHub 86](https://github.com/andrew-worsfold/tailor/pull/86).
* Improved - Sidebar styles to match the Customizer.
* Changed - Default placeholder text for Content elements.
* Fixed - tailor_get_users() query retrieves unnecessary information [GitHub 94](https://github.com/andrew-worsfold/tailor/pull/94).
* Fixed - Sidebar styles affecting search field within WordPress Media Modal [GitHub 98](https://github.com/andrew-worsfold/tailor/issues/98).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.