From efca97a1fac720290ac0181a41a8971ae945f1bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20Felipe=20Barco=20Santa?= Date: Tue, 15 Nov 2022 20:09:23 -0500 Subject: [PATCH] Removing unnecessary code --- WORKSPACE | 11 ----------- typescript/BUILD | 8 +------- typescript/main.ts | 4 ++-- typescript/package.json | 3 +-- typescript/pnpm-lock.yaml | 6 ------ typescript/tsconfig.json | 3 +-- 6 files changed, 5 insertions(+), 30 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index a9d93458..03305a90 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -203,14 +203,3 @@ nodejs_register_toolchains( load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() - -load("@aspect_rules_js//npm:npm_import.bzl", "npm_translate_lock") - -npm_translate_lock( - name = "npm", - pnpm_lock = "//typescript:pnpm-lock.yaml", -) - -load("@npm//:repositories.bzl", "npm_repositories") - -npm_repositories() diff --git a/typescript/BUILD b/typescript/BUILD index a1329565..50df42ee 100644 --- a/typescript/BUILD +++ b/typescript/BUILD @@ -1,17 +1,11 @@ load("@aspect_rules_ts//ts:defs.bzl", "ts_project") load("@bazel_skylib//rules:build_test.bzl", "build_test") -load("@npm//:defs.bzl", "npm_link_all_packages") - -npm_link_all_packages(name = "node_modules") ts_project( name = "typescript", srcs = ["main.ts"], declaration = True, - out_dir = ".", - deps = [ - "//typescript:node_modules/@types/node", - ], + out_dir = "." ) build_test( diff --git a/typescript/main.ts b/typescript/main.ts index 15d3f1a0..355c7495 100644 --- a/typescript/main.ts +++ b/typescript/main.ts @@ -1,4 +1,4 @@ export const hello: String = "Hello "; -export const world: String = "World " +export const world: String = "World "; -console.log(hello, world) \ No newline at end of file +console.log(hello, world); diff --git a/typescript/package.json b/typescript/package.json index 54dc0c3e..334679f4 100644 --- a/typescript/package.json +++ b/typescript/package.json @@ -1,7 +1,6 @@ { "private": true, "dependencies": { - "@types/node": "18.6.1", "typescript": "4.8.2" } -} \ No newline at end of file +} diff --git a/typescript/pnpm-lock.yaml b/typescript/pnpm-lock.yaml index 35df6e45..5273482e 100644 --- a/typescript/pnpm-lock.yaml +++ b/typescript/pnpm-lock.yaml @@ -1,19 +1,13 @@ lockfileVersion: 5.4 specifiers: - '@types/node': 18.6.1 typescript: 4.8.2 dependencies: - '@types/node': 18.6.1 typescript: 4.8.2 packages: - /@types/node/18.6.1: - resolution: {integrity: sha512-z+2vB6yDt1fNwKOeGbckpmirO+VBDuQqecXkgeIqDlaOtmKn6hPR/viQ8cxCfqLU4fTlvM3+YjM367TukWdxpg==} - dev: false - /typescript/4.8.2: resolution: {integrity: sha512-C0I1UsrrDHo2fYI5oaCGbSejwX4ch+9Y5jTQELvovfmFkK3HHSZJB8MSJcWLmCUBzQBchCrZ9rMRV6GuNrvGtw==} engines: {node: '>=4.2.0'} diff --git a/typescript/tsconfig.json b/typescript/tsconfig.json index 4518d7d2..f870069a 100644 --- a/typescript/tsconfig.json +++ b/typescript/tsconfig.json @@ -1,7 +1,6 @@ { "compilerOptions": { "declaration": true, - "baseUrl": ".", - "types": ["node"] + "baseUrl": "." } } \ No newline at end of file