Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
issue #25 HTTP last modified header #27
I have added an Etag header in the HTTP response.
The Etag is a hash of :
If the Etag form the request match the one we are calculating for the response, we return a 304
Feedback welcome, I am sure there are plenty of things to improve :)
I like the code and approach, thanks! :)
but I've some nitpicky comments:
I'd ignore the last item (if it works good enough in practise, there's no need to add complexity of requests containing a list of etags; also the * seems to be there for interaction with if-none-match and if-modified-since); but if you could work on the minor previous nitpicks (and rebase to current master), that'd be hugely appreciated! :)
@Engil that file is slightly messy.. could you maybe remove it (and maybe massage git in a way that a clone won't need to download it; yes it'll mess up hash ids, but imho it would be good to do)
I think an assets tarball could be distributed out of band for those not having npm, browserify, lessc. The config.ml should use
I assumed bundling the tar file inside the repo would be alright, sorry about that.
So how should we distribute them ? If I recall correctly, Github allows uploading static assets when doing a release so it should be the rightful place to store the assets, but I'm not sure.
Once this branch is cleaned of the tarball (really sorry about that @voila, this is my fault for not being patient enough when merging PRs…) I will clean the main branch from all tarball bits and we'll find a way to distribute assets correctly. :)