New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New css #38

Merged
merged 4 commits into from May 3, 2016

Conversation

Projects
None yet
3 participants
@Engil
Copy link
Owner

Engil commented Apr 29, 2016

This PR introduce a new default CSS. (this was something I wrote for my own blog first, but then I thought why not merging it since the current one isn't really nice.)
Colors are probably a bit opinionated (versus white and grey), so either everyone is pleased with it or I can keep the old one and backport a few fixes in it (most notably: changing the font that was criticized for not being easy to read).

Sample screenshots:

capture d ecran 2016-04-29 a 15 26 26
capture d ecran 2016-04-29 a 15 28 20

Engil added some commits Apr 27, 2016

@avsm

This comment has been minimized.

Copy link
Contributor

avsm commented Apr 29, 2016

i like it!

On 29 Apr 2016, at 16:12, Enguerrand Decorne notifications@github.com wrote:

This PR introduce a new default CSS. (this was something I wrote for my own blog first, but then I thought why not merging it since the current one isn't really nice.)
Colors are probably a bit opinionated (versus white and grey), so either everyone is pleased with it or I can keep the old one and backport a few fixes in it (most notably: changing the font that was criticized for not being easy to read).

Sample screenshots:

https://cloud.githubusercontent.com/assets/146049/14919157/5f4f4074-0e1f-11e6-9134-70e23e3198bd.png
https://cloud.githubusercontent.com/assets/146049/14919163/65ec3bc6-0e1f-11e6-8ef7-9e53a3b982ac.png
You can view, comment on, or merge this pull request online at:

#38 #38
Commit Summary

Change the default css
Change a few sizes
Update assets file
File Changes

M assets/assets_generated.tar.gz https://github.com/Engil/Canopy/pull/38/files#diff-0 (0)
M assets/less/partials/atoms.less https://github.com/Engil/Canopy/pull/38/files#diff-1 (6)
M assets/less/partials/constants.less https://github.com/Engil/Canopy/pull/38/files#diff-2 (3)
M assets/less/partials/layout.less https://github.com/Engil/Canopy/pull/38/files#diff-3 (2)
M assets/less/partials/navbar.less https://github.com/Engil/Canopy/pull/38/files#diff-4 (212)
M assets/less/partials/typography.less https://github.com/Engil/Canopy/pull/38/files#diff-5 (17)
M assets/less/style.less https://github.com/Engil/Canopy/pull/38/files#diff-6 (2)
Patch Links:

https://github.com/Engil/Canopy/pull/38.patch https://github.com/Engil/Canopy/pull/38.patch
https://github.com/Engil/Canopy/pull/38.diff https://github.com/Engil/Canopy/pull/38.diff

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub #38

@hannesm

This comment has been minimized.

Copy link
Collaborator

hannesm commented Apr 29, 2016

hmm, maybe a theme chooser is the way to go for real now? ;) i like the new one as well

@Engil

This comment has been minimized.

Copy link
Owner

Engil commented May 3, 2016

Yup, in the long run a theme chooser would be nice.
Or whatever the solution will be for handling nicer templating. (one day, probably, I will find some time to answer this question… 🙃)
Merging, since it fixes a few problems (no more crashing when using a KV_RO on Xen since the font file is gone, better readability (some people reported that the old font wasn't great)), and it's somehow prettier.

@Engil Engil merged commit 6fa5fb6 into master May 3, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hannesm hannesm deleted the new-css branch Oct 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment