New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom radix sort for ordering blocks #1277
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octylFractal
added
type:performance
Performance-related issue
status:accepted
Will be fixed / added to WorldEdit, eventually
labels
Mar 30, 2020
me4502
approved these changes
Mar 31, 2020
wizjany
approved these changes
Mar 31, 2020
Codecov Report
@@ Coverage Diff @@
## master #1277 +/- ##
===========================================
- Coverage 12.51% 9.67% -2.84%
+ Complexity 950 845 -105
===========================================
Files 761 762 +1
Lines 32165 32259 +94
Branches 3853 3866 +13
===========================================
- Hits 4024 3120 -904
- Misses 27810 28841 +1031
+ Partials 331 298 -33 Continue to review full report at Codecov.
|
octylFractal
force-pushed
the
feature/radix-sorting
branch
2 times, most recently
from
March 31, 2020 22:01
4945fa4
to
beb2908
Compare
octylFractal
force-pushed
the
feature/radix-sorting
branch
from
March 31, 2020 22:14
beb2908
to
7133987
Compare
wizjany
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status:accepted
Will be fixed / added to WorldEdit, eventually
type:performance
Performance-related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions for improvement are welcome, but as this class has been heavily benchmarked against stream parallel sort, changes should result in a significant positive performance difference.