Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom radix sort for ordering blocks #1277

Merged
merged 6 commits into from Apr 1, 2020
Merged

Conversation

octylFractal
Copy link
Member

Suggestions for improvement are welcome, but as this class has been heavily benchmarked against stream parallel sort, changes should result in a significant positive performance difference.

@octylFractal octylFractal added type:performance Performance-related issue status:accepted Will be fixed / added to WorldEdit, eventually labels Mar 30, 2020
@octylFractal octylFractal added this to To do in Block Placement Improvements via automation Mar 30, 2020
Block Placement Improvements automation moved this from To do to In progress Mar 31, 2020
@codecov-io
Copy link

codecov-io commented Mar 31, 2020

Codecov Report

Merging #1277 into master will decrease coverage by 2.83%.
The diff coverage is 89.47%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1277      +/-   ##
===========================================
- Coverage     12.51%   9.67%   -2.84%     
+ Complexity      950     845     -105     
===========================================
  Files           761     762       +1     
  Lines         32165   32259      +94     
  Branches       3853    3866      +13     
===========================================
- Hits           4024    3120     -904     
- Misses        27810   28841    +1031     
+ Partials        331     298      -33     
Impacted Files Coverage Δ Complexity Δ
.../worldedit/extent/reorder/ChunkBatchingExtent.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...dit/internal/util/RegionOptimizedVectorSorter.java 92.39% <92.39%> (ø) 23.00 <23.00> (?)
...va/com/sk89q/worldedit/world/block/BlockTypes.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...k89q/worldedit/util/concurrency/LazyReference.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...va/com/sk89q/worldedit/util/io/file/MorePaths.java 0.00% <0.00%> (-85.72%) 0.00% <0.00%> (-2.00%)
.../sk89q/worldedit/util/eventbus/HierarchyCache.java 23.52% <0.00%> (-76.48%) 1.00% <0.00%> (-4.00%)
.../com/sk89q/worldedit/util/collection/BlockMap.java 0.00% <0.00%> (-70.78%) 0.00% <0.00%> (-38.00%)
...sk89q/worldedit/extension/platform/Preference.java 0.00% <0.00%> (-66.67%) 0.00% <0.00%> (-1.00%)
...9q/worldedit/world/registry/BundledRegistries.java 0.00% <0.00%> (-62.50%) 0.00% <0.00%> (-3.00%)
...c/main/java/com/sk89q/worldedit/util/Location.java 0.00% <0.00%> (-56.46%) 0.00% <0.00%> (-19.00%)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 404feef...7133987. Read the comment docs.

@octylFractal octylFractal force-pushed the feature/radix-sorting branch 2 times, most recently from 4945fa4 to beb2908 Compare March 31, 2020 22:01
@octylFractal octylFractal merged commit bb013aa into master Apr 1, 2020
Block Placement Improvements automation moved this from In progress to Done Apr 1, 2020
@octylFractal octylFractal deleted the feature/radix-sorting branch April 1, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted Will be fixed / added to WorldEdit, eventually type:performance Performance-related issue
Development

Successfully merging this pull request may close these issues.

None yet

4 participants