Permalink
10 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
1 changed file
with
14 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbd1a0eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but shooting with an arrow on an item frame isnt covered yet, since this check isnt present in onEntityDamageByProjectile.
And in my opinion this should be done in WorldGuardHangingListener.java
bbd1a0eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why so we have to register the same event twice?
bbd1a0eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.. yeah thats true, indeed
i was just thinking about the clearness.
forget the second part of the last post.
bbd1a0eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't realize other entities did it too, thought it was just players punching it. should be fixed in 2d90fdd
bbd1a0eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to say, but this isn't fixed...
Players are still removing items from item frames by..
1: Hitting them with Enderpearls
2. Shooting them with arrows.
3. Possibly snowballs and any other projectiles.
Region is flagged correctly, and I am running the latest dev build (5.9.1 / 1289) | Spigot 1225
bbd1a0eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may help, it's shooting a NoSuchMethod error quite a lot when I try to shoot the item frame.
http://gld.bz/c/0965c.png
I may admit, the Spigot version of mine is a bit old, but the API changes were made at that time. It's currently on a production server, and I have the issue on a development server with the latest of everything.
bbd1a0eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the 5.9 release version for that version of craftbukkit.
the bukkit team made some breaking changes so new (snapshot) versions of worldguard need a more recent bukkit version as well.
bbd1a0eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems to have done the trick, thanks for the suggestion, I wonder why it wasn't working on the dev server?
Huh, oh well.
(Updated to latest spigot, and WG dev build)
bbd1a0eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have the latest worldedit on that dev server as well?
bbd1a0eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the latest release on the Dev server.
On production I have latest dev of WG/WE/Spigot, and that combination seems to work.