New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name all the recipes #4858
Merged
Merged
Name all the recipes #4858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubejs/server_scripts/enigmatica/kubejs/base/recipetypes/thermal/dynamo/lapidary.js
Show resolved
Hide resolved
kubejs/server_scripts/enigmatica/kubejs/base/recipetypes/thermal/machine/insolator_catalyst.js
Show resolved
Hide resolved
kubejs/server_scripts/enigmatica/kubejs/normal/recipetypes/astralsorcery/block_transmutation.js
Show resolved
Hide resolved
kubejs/server_scripts/enigmatica/kubejs/normal/recipetypes/astralsorcery/block_transmutation.js
Show resolved
Hide resolved
kubejs/server_scripts/enigmatica/kubejs/normal/recipetypes/mythicbotany/infusion.js
Show resolved
Hide resolved
Awaiting one or both of these getting merged: Darkhax-Minecraft/BotanyPots#227 Darkhax-Minecraft/BotanyPots#226
NielsPilgaard
approved these changes
May 18, 2022
Ready to merge, or do you want to wait for a potential bug fix in Botany Crops? |
I have exempted botany pots from the fallback id so we don't have to wait on it for now ^-^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
:kjs_
recipe ids are hard to track down, this pull request will get rid of all of them.Using the CI script i have tracked down all recipes that lack a custom id, at first i tried to fix all of them by hand but that proved pretty much impossible due to avoiding duplicate name conflicts in unification scripts, as well as deciding a name.
In this pull request the easy/small ones are given a prefix & name by hand, but for the larger bulk i have introduced a helper function called
md5
, which basically takes the part from after:kjs_
and puts the suppliedid_prefix
in front of it.This will help to find where the random ids are defined, but avoids the effort required for coming up with naming schemes.
Therefore this is a compromise, ideally we'd have all recipes named by hand, but these are at least a little easier to maintain since the id points to the right file (& function) responsible for adding the recipe.
Once this is merged one simply has to search for
md5
in the kubejs scripts to find which recipes still require a manual name, this pull request is not the end goal but merely a stepping stone.Before i'll turn draft mode off i'll go over it using the github checkboxes to clean it up a little more, but after that it should be good to go.
I have checked that no added recipes got lost by comparing the
added
recipes file of the ci of the base & pull branch:Strangely this returns
[ 20403, 20402 ]
, so no recipes got lost but one slipped in, should be no cause for concern. 🤔