Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semi-colons not rendering in both inline and block statements #15

Closed
dan-j opened this issue Aug 4, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@dan-j
Copy link

commented Aug 4, 2015

I am using v2.8 of the wordpress plugin and have dropped in the latest version of EnlighterJS, v2.8 (I noticed the plugin was still using EnlighterJS v2.7). The examples below are all using lang="java" however I have verified the same also happens for lang="php"

The following snippets aren't rendering the final semi-colon.

This is an [java]"inline";[/java] string.
[java]
"string";

[/java]

The following does seem to work, so it seems to only occur if the semi-colon is the last character. Spaces and tabs (but not newlines) causes the semi-colon to print.

This is an [java]"inline;" [/java] string.
[java]
"string";
a
[/java]

Hope this helps. If you have ideas where the issue is I can have a look at fixing it.

@AndiDittrich

This comment has been minimized.

Copy link
Member

commented Aug 5, 2015

Dear dan-j,
thanks for your report.

i can only reproduce this behaviour using inline code - it works fine on codeblocks.
do you have an example/demo page which shows the issue ?

@AndiDittrich AndiDittrich added this to the 2.9 milestone Aug 5, 2015

@AndiDittrich AndiDittrich self-assigned this Aug 5, 2015

@dan-j

This comment has been minimized.

Copy link
Author

commented Aug 5, 2015

I'm currently just creating a Wordpress site locally that I'm not hosting yet. I'll look into it again tonight and see if I can get an example somewhere.

Cheers

Sent from my iPhone

On 5 Aug 2015, at 09:11, Andi Dittrich notifications@github.com wrote:

Dear dan-j,
thanks for your report.

i can only reproduce this behaviour using inline code - it works fine on codeblocks.
do you have an example/demo page which shows the issue ?


Reply to this email directly or view it on GitHub.

@AndiDittrich

This comment has been minimized.

Copy link
Member

commented Aug 5, 2015

i've localized the issue: It's an (hopefully final) bug within the EnlighterJS Tokenizer Engine.
It only appears on a single "non-token" character as last element.

i will fix it with EnlighterJS v2.8.1 in the next hours

@dan-j

This comment has been minimized.

Copy link
Author

commented Aug 5, 2015

Ah that's good. Look forward to seeing it.

Sent from my iPhone

On 5 Aug 2015, at 09:24, Andi Dittrich notifications@github.com wrote:

i've localized the issue: It's an (hopefully final) bug within the EnlighterJS Tokenizer Engine.
It only appears on a single "non-token" character as last element.

i will fix it with EnlighterJS v2.8.1 in the next hours


Reply to this email directly or view it on GitHub.

@AndiDittrich

This comment has been minimized.

Copy link
Member

commented Aug 5, 2015

EnlighterJS v2.9.0 is out including the fix - i'm currently woriking on the WordPress plugin to update it asap

@AndiDittrich

This comment has been minimized.

Copy link
Member

commented Aug 8, 2015

Enlighter 2.9 for WordPress has been released including the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.