From bdad449f8614a55e612460ca2039814ad13e6c93 Mon Sep 17 00:00:00 2001 From: Matthieu Barba Date: Fri, 28 Apr 2017 14:40:20 +0100 Subject: [PATCH] Fix loop on sample synonyms in get_all_Samples Two parts bug: instead of looping on all sample_synonyms, only the first synonym was retrieved at first. So the array ref was dereferenced in a previous commit, but the second part of the bug was not fixed, which lead to a string being used as an array. --- modules/Bio/EnsEMBL/Variation/VCFCollection.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/Bio/EnsEMBL/Variation/VCFCollection.pm b/modules/Bio/EnsEMBL/Variation/VCFCollection.pm index b2d5e3430e..89ba2f7d34 100644 --- a/modules/Bio/EnsEMBL/Variation/VCFCollection.pm +++ b/modules/Bio/EnsEMBL/Variation/VCFCollection.pm @@ -516,7 +516,7 @@ sub get_all_Samples { for my $sample_name (keys %sample_objs) { my $sample = $sample_objs{$sample_name}; for my $syn (@{$sample->get_all_synonyms}) { - $synonyms{$syn->[0]} = $sample->name; + $synonyms{$syn} = $sample->name; } }