New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Rust sample bot #9

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@JWorthe
Contributor

JWorthe commented May 1, 2018

Evening folks,

This is my pull request to include support for the Rust programming language.

Just a few notes on things that didn't quite match up with the instructions:

  1. The instructions say I need a bot.json file, but none of the other bots seem to have one for me to see the format. Do I need a bot.json and what should be in it?
  2. The instructions also mention command line arguments. Looking at the BotRunners, it looks like only the python bot actually passes any command line arguments. Is there anything in particular that I should be taking in?

I mention this in the readme, but it's a potential cross-platform tripping hazard that the filename of the compiled executable is going to be different between Windows and Linux. It'll be mostly the same, but on Windows it will end in .exe.

Thanks,
Justin

@FoamyZA

This comment has been minimized.

Collaborator

FoamyZA commented May 2, 2018

Hi @JWorthe please remove this pull request and make a new one into develop, it looks good and will be merged into develop.

@JWorthe

This comment has been minimized.

Contributor

JWorthe commented May 2, 2018

Thanks Gerhard. New merge request is up here: #17

@JWorthe JWorthe closed this May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment