New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FizzStringReturner may not have copied all characters #281

Merged
merged 1 commit into from Feb 4, 2017

Conversation

Projects
None yet
2 participants
@tkellogg

tkellogg commented Feb 3, 2017

I noticed that the String construtor was being called without specifying
the start offset and count. This is unacceptable. How do I know if it's
copying all the characters unless I can actually see it in the code. In
this change, you'll get the distinct air of superiority as you have now
begun dealing with low-level constructs such as arrays. As they say, rub
on some arrays, and watch the women flock.

Tim Kellogg
FizzStringReturner may not have copied all characters
I noticed that the String construtor was being called without specifying
the start offset and count. This is unacceptable. How do I know if it's
copying all the characters unless I can actually see it in the code. In
this change, you'll get the distinct air of superiority as you have now
begun dealing with low-level constructs such as arrays. As they say, rub
on some arrays, and watch the women flock.
@emiln

This comment has been minimized.

Show comment
Hide comment
@emiln

emiln Feb 4, 2017

Member

This is precisely the kind of high quality community contribution that helps maintain a true Enterprise quality codebase. Thank you.

Member

emiln commented Feb 4, 2017

This is precisely the kind of high quality community contribution that helps maintain a true Enterprise quality codebase. Thank you.

@emiln emiln merged commit cdfac75 into EnterpriseQualityCoding:master Feb 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment