New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add META.json file to repository #24

Merged
merged 2 commits into from Jan 30, 2017

Conversation

Projects
None yet
2 participants
@monsieurp
Contributor

monsieurp commented Jan 29, 2017

Hello there

I'm participating in the CPAN Pull Request Challenge 2017 and I've been given your distribution for my January assignment.

According to http://cpants.cpanauthors.org/kwalitee/has_meta_json, your dist file does not generate a META.json. Here it is with this PR.

Looking forward to reading your feedback.

Cheers!

monsieurp added some commits Jan 29, 2017

@zmughal

This comment has been minimized.

Show comment
Hide comment
@zmughal

zmughal Jan 30, 2017

Member

Thanks for the catch!

Just a side note: I believe that the META.json file doesn't need to be in the repository if the Dist::Zilla MetaJSON plugin is enabled (it gets generated at build time). I'll remove it myself if that is the case.

Member

zmughal commented Jan 30, 2017

Thanks for the catch!

Just a side note: I believe that the META.json file doesn't need to be in the repository if the Dist::Zilla MetaJSON plugin is enabled (it gets generated at build time). I'll remove it myself if that is the case.

@zmughal zmughal merged commit 6ffac7e into EntropyOrg:master Jan 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment