Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Branch rearrangements, Environmental feature, Environment #163
Comments
|
Logged In: YES I think this seems like a sensible course of action. However I would like to have other peoples thoughts before committing changes as this would be a high level branch rearrangement. Original comment by: normanmorrison |
|
- assigned_to: nobody —> normanmorrison Original comment by: normanmorrison |
|
Logged In: YES I strongly vote against. The is_a/part_of mutual cyclicity is a massive warning flag And we have a cyclicity in the definitions – EF is defined using environment, but E is_a EF Original comment by: cmungall |
|
Logged In: YES I was thinking of this as well, but I was thinking that the environment was the top node: environment Lynn Original comment by: lynn_schriml |
cmungall commentedDec 7, 2007
Bary Smith Wrote:
-——-can we work on this?
name: environmental feature
def: “A feature that is part of the totality of circumstances external to a definable entity.” [NM:nm]
The problem is that all (?) the environmental features listed are parts of the geospatial realm, e.g.
name: habitat
def: “A spatial region having environmental qualities which may sustain an organism or a community of organisms.” [EnvO:EnvO]
synonym: “biotope” RELATED []
is_a: ENVO:00002297 ! environmental feature
I like this definition much more.
My recommendation would be to create the new root, environment, define environmental feature explicitly as a feature that is part of an environment (environmental feature will still have to be an is-a root) put habitat as an environment for a group of organisms and thing of another term (niche?) for an environment of a single organism.
environment is_a environmental feature
at the same time we have:
environmental_feature part_of environment
Original comment by: normanmorrison