Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Obsolete '' Animal manure'' and create ''animal dung'' #348
Comments
|
Is there a difference between dung and feces? If not, we can subclass feces. |
pbuttigieg
referenced
this issue
Nov 22, 2016
Open
Animal manure should not be classified as a waste material #320
|
Also, is there any difference between manure and feces? If not, we can obsolete In this case, AgrO can just import it. |
pbuttigieg
self-assigned this
Nov 22, 2016
celineaubert
commented
Nov 22, 2016
|
There is a slight difference. There are different types of animal manure : feces only, farmyard manure (feces+urine+vegetal like straw) or farm slurry (urine only). |
pbuttigieg
added a commit
that referenced
this issue
Nov 22, 2016
|
|
pbuttigieg |
99ed0e8
|
|
Okay, got it. So ENVO will keep the classes ( You could also split that up if you need to. |
|
PS: we need |
|
we also have feces here: UBERON:0001988 ! feces But an instance of this is a portion from a single animal. animal manure is combined portions, possibly with other stuff mixed in. as for
I am not a fan of disjunctive definitions, often a bad smell (in the coder's sense of bad smell, not the manure sense). Also
My definition would be:
I generally favor replacing roles with capable-of to the realizing process, but if we really want to name roles:
maybe fertilizer is too specific, it can also be a soil amender. the crucial point here is that 'resource' is unsufficiently specific. There is an argument for replacing derives-from with composed-primarily-of. It depends how we view the feces lifecycle. When does it stop being feces? I don't have strong opinions. For the disjunctive clause, how about instead just having subclasses:
lastly, regarding which ontology things go in. I want to caution against the situation where we have reciprocal dependencies. This can be a major headache. |
Good point, didn't think about restrictions on instances. ENVO's
I think this will have to reviewed by the agronomy crowd, we should capture this in a comment.
Fine with that. @celineaubert we'll keep this in ENVO for now while these semantic issues are worked on. AgrO can import them and not worry about this for now. We'll surrender them over when they are stable. This also avoids the reciprocal dependencies at too early a stage. |
mark-jensen
commented
Nov 23, 2016
We have it in SDGIO, along with the realization process.
I think it's ok to leave the nature of "benefit" open. But 'consumer' may not be the best choice, since it implies the actual use of the resource, whereas a body of water, stand of trees, money in the bank can all be resources. Putting it aside for future use/consumption makes it a resource, so consumption is not necessary. |
pbuttigieg
referenced
this issue
Jan 20, 2017
Closed
A number of anthropogenic and other terms for our GenEpiO #460
Public-Health-Bioinformatics
commented
Jan 21, 2017
•
|
@cmungall about "I generally favor replacing roles with capable-of to the realizing process,". Is the primary idea that we can claim that an entity be capable-of realizing some objective (or engaging in some process), e.g. 'doctor: person and capable-of some "provision-of medical diagnosis and advice" '. Then one could say an entity "has role" some [role name] during the time it is realizing the aforementioned objective or process participation? "Though I have many hats, I'm wearing my doctor hat when I say to you bla bla ...". (I might be messing with BFO though in reducing semantics of "has role" from its previous scope of a) being the way one defined what an entity was capable of; and b) being attached to an entity even when it was not being realized.) Hmm. Underlying many definitions is a seeping "intentionality", a kind of future contract. Our use of crap vs manure is about a possible or intended future of the entity, not anything an instrument can distinguish in the now. So I'm seeing an ontology pattern in which a class definition is stripped of intentionality, and where its subclasses DO enable intentionality differentia e.g.
the capability-of part is the intentionality part. In a conversational dialog, use of "animal manure" cues the intention of its use, even though many other logical capabilities (e.g. fecal transplant material) are inherent in the entity. So to set the stage for "resource role"
then maybe |
celineaubert commentedJul 21, 2016
Hi,
As we discussed on Skype, the ''Animal manure'' class may be obsoleted in ENVO and created in AgrO.
ENVO could create the class ''animal dung'' that will be imported in AgrO, and used as follows: "animal manure" is primarily composed of "animal dung".