Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
deprecated ENVO:mushroom #464
Comments
|
@Public-Health-Bioinformatics: any chance this will be released in FOODON soon? @zhengj2007 we may have to check that "mushroom" in FOODON is equivalent to what you need. What kind of mushrooms are you dealing with (e.g. wild mushrooms growing in a forest, mushroom products, ...)? |
Public-Health-Bioinformatics
commented
Mar 3, 2017
|
Ah, so I just cleaned up the deprecated terms last night. I'm happy to move it all over - its just that I'm still not quite sure what the "core" should be - a single .owl file or can it still be based on includes? Happy to move it over and then work on massaging the core together if you'd like? |
|
@Public-Health-Bioinformatics I think @zhengj2007 just needs a PURL at this stage (correct me if I'm wrong), however, @zhengj2007 could you specify what you mean by mushroom? |
Public-Health-Bioinformatics
commented
Mar 7, 2017
|
Mushroom purl: http://purl.obolibrary.org/obo/FOODON_00001287 |
zhengj2007
commented
Mar 7, 2017
|
@pbuttigieg We used 'mushroom' to annotate the source of specimen (e.g. parasite isolate) that collected from. So, it is not clear what kind of mushrooms, could be either growing in a forest or farm or lab. |
zhengj2007
commented
Mar 7, 2017
|
@Public-Health-Bioinformatics I cannot find FOODON: mushroom on the http://www.ontobee.org. So, I cannot import the term from FOODON using ontoFox. Is the ontology on ontobee.org site out-of-date? The available version on the onto is: http://purl.obolibrary.org/releases/2016-03-17/foodon.owl |
Public-Health-Bioinformatics
commented
Mar 7, 2017
|
Ah I see. I'll ask OntoBee and OntoFox to get FoodOn updated - I just uploaded all the new FoodOn work including this term to https://github.com/FoodOntology/foodon last night, so not surprised OntoBee/OntoFox doesn't see it. |
zhengj2007
commented
Mar 7, 2017
|
Thanks! The issue is solved when FOODON: mushroom is available. |
Public-Health-Bioinformatics
commented
Mar 7, 2017
|
Note, we do have a http://purl.obolibrary.org/obo/FOODON_3306538 wild mushroom (raw) in the subset_siren_import.owl file as a type of food product. I'm just getting feedback about that new import file though. |
|
what is the relationship to http://purl.obolibrary.org/obo/FAO_0000012
basidiocarp
…
|
Public-Health-Bioinformatics
commented
Mar 7, 2017
|
(p.s. if NCBI taxonomy can't do a good job of matching to fungi, then FoodOn could use another ontology's taxonomy terms there.) |
Public-Health-Bioinformatics
commented
Mar 24, 2017
|
Update: Ontobee now has Foodon loaded. Mushroom is: http://purl.obolibrary.org/obo/FOODON_00001287 |
pbuttigieg
added a commit
that referenced
this issue
Mar 24, 2017
|
|
pbuttigieg |
4ae859d
|
|
Great! Thanks @Public-Health-Bioinformatics! I set up the FOODON import for ENVO and added `mushroom environment' in 4ae859d @zhengj2007 I'll make a release today or tomorrow so you can use The yet-to-be-released ENVO PURL for |
zhengj2007
commented
Mar 24, 2017
|
@pbuttigieg @Public-Health-Bioinformatics Thanks a lot! |
|
@Public-Health-Bioinformatics, @cmungall asked above:
I suppose FOODON will have to tackle this somehow as it's in the FAO space, would this partner with UBERON or are there strange, non-anatomical definitions due to transnational labelling etc? |
Public-Health-Bioinformatics
commented
Mar 24, 2017
|
@pbuttigieg @zhengj2007 Isn't there a bit of a combination bomb in pairing environment + plant reference with respect to future vocabulary additions? Or is this unavoidable? |
|
@cmungall and I were discussing this for animal environments (e.g. human guts). It is indeed a combination bomb, so we may create sub-ontologies dedicated to each major taxon for easy imports. |
|
Uberon covers metazoa, so the FAO strategy would be analogous. |
|
Closed in this release |
pbuttigieg
closed this
Mar 27, 2017
zhengj2007
commented
May 4, 2017
|
@pbuttigieg I think we still need an ENVO:mushroom. The FOODON: mushroom is a subClass of food source. However, I don't think all mushroom can be food since some mushroom are poisonous and can be taken as food. FOODON: mushroom is a mushroom has_role food role. Is it possible to reverse ENVO:mushroom deprecation? |
Public-Health-Bioinformatics
commented
May 4, 2017
•
|
Ah. This brings up a point we were grappling with in the last few weeks which FoodOn needs improvement on. Not everything is food for everything else, but rather an organism is almost invariably food for some other organism (I'd like to hear the case where this isn't true!). So to address your concern I was thinking of this move:
Then underlying food sources can list off the particular organism taxon, part, and the consumer taxon(s) or related groups of consumers (e.g. cow's milk has consumer human infant). Hopefully more general edibles can reference more general groups of consumers rather than having giant lists of consumers for each food. This would also address allergens insofar as we're not saying ALL humans can eat some food source (e.g. seafood); just that some of them can. More conditionals about allergens could be tacked onto the consumer groups I suppose, like milk as a food product: "is a [milk: UBERON_0001913] and part of some cow and has consumer lactose-tolerant homo sapiens". |
zhengj2007
commented
May 5, 2017
|
@Public-Health-Bioinformatics What you proposed sounds good to me. Thanks! |
zhengj2007 commentedFeb 15, 2017
@pbuttigieg We used ENVO:mushroom in our annotation. In latest release, the term is deprecated and indicated replaced by: FOODON_00001287
(http://www.ontobee.org/ontology/ENVO?iri=http://purl.obolibrary.org/obo/ENVO_02000072)
However, I searched latest release version of FOODON. I cannot find either 'mushroom' or term ID:FOODON_00001287.
Any suggestion on dealing with the issue?
Thanks,
Jie