Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
new/ updated classes: glaciers, glacial ice & erosionally enriched ice #473
Comments
kaiiam
changed the title from
new/ updated classes: glaciers and glacial ice to new/ updated classes: glaciers, glacial ice & erosionally enriched ice
Mar 27, 2017
|
Yes, this looks actionable right now. We may need to think about how to structure the erosional processes and the materials they generate: The issue is that this can explode the number of process-enriched, feature located terms. We'll see where it goes, but keep that in mind. |
pbuttigieg
added
to TODO in cryophile
Mar 27, 2017
|
ok @pbuttigieg I've revamped definition for glacier, added glacial ice as subclass of ice mass, added erosionally enriched glacial ice as subclass of ice mass (under geographic feature). We still have the issue of the ice mass hierarchy occurring in duplicate once under geographic feature and once as ice mass independently, both of which are subclasses of environmental feature. We should address this, thoughts? Finally I added glacial erosion process as subclass of erosion. |
|
Hi @kaiiam
The new terms should be in the material hierarchy, not the feature hierarchy. You have some glacial ice, not a glacial ice: if it's not countable (a lake, a building, etc) but more a mass or a volume (some water, some ice, etc.) it should be in the material hierarchy. If you created classes like
We'll do this later today before you send in the PR.
Great! |
|
Agreed @pbuttigieg, lets sort this out together later today when we do the PR. |
pbuttigieg
moved
from TODO to In Progress in cryophile
Mar 28, 2017
|
@pbuttigieg, we finished this during pull request 2 for project cryophile #481 |
kaiiam commentedMar 27, 2017
•
edited by pbuttigieg
Hey @pbuttigieg we previously dicussed here and here the need for the term glacial ice.
we currently have glacier defined as:
we discussed changing glacier's definition to:
As we previously discussed glacial ice could be defined
As subset of glacial ice or subset of ice with some sort of link to glacier we could add 'erosionally enriched glacial ice'
Where 'glacial erosion process' can be defined as