Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
new classes: phase transition process & relevant subclasses #474
Comments
|
Do these not exist in a chemical or reaction ontology? If you can't find
satisfactory classes elsewhere, please start drafting the classes.
…
|
|
I like the way this article discusses phase transitions as it's a little more clear on what's going on in the material. I would prefer a little more depth in at least the top level defs. |
|
[REX:0000171](http://purl.obolibrary.org/obo/REX_0000171) ! phase
transition
The ontology is abandoned AFAICT, if it looks like we'll need to make
modifications to it we can discuss with the wider OBO community
…
|
|
Thanks for the link @cmungall, I think we should ask the community if we can edit REX - it would be a real asset for ENVO and many others. |
pbuttigieg
added
to TODO in cryophile
Mar 27, 2017
|
Thank you @cmungall for chiming in. @pbuttigieg I assume it would be best if we were to hold off on adding the phase transition terms until we know if REX is the right place to put them and if we get edit permissions. I would, however, like to add the compaction process, material accumulation process, material transport process terms to ENVO. Would it be ok to do so as I currently have them defined? |
Agreed.
Generally yes (switch the wherbys to 'during which's. We may do some minor edits to the defs later, but they're okay for now. @cmungall is there a procedure for approaching the community regarding REX? Should we try to contact the lead developer first? Jana Hastings is still listed as the contact, but she's no longer with the EBI. |
|
I'd also like to add material transformation process
@pbuttigieg is that ok for now? |
pbuttigieg
moved
from TODO to In Progress in cryophile
Mar 28, 2017
|
On 28 Mar 2017, at 7:03, Pier Luigi Buttigieg wrote:
> ***@***.***(<https://github.com/pbuttigieg>) I assume it would be
> best if we were to hold off on adding the phase transition terms
> until we know if REX is the right place to put them and if we get
> edit permissions.
Agreed.
I wonder if there is a split analogous to the mixture-molecular entity
split in CHEBI, with basic physical processes at the level of atoms and
sub-atomic particles in REX, and mixture-level processes like freezing
at a higher level of granularity (with ENVO being a natural home for the
latter). If so, these would ultimately be linked by something like
has_part, but you could certainly defer on linking to the lower level of
granularity for now.
|
|
@kaiiam for compaction, see #426, we may be able to do something quite general @cmungall I agree with the process part approach between REX and ENVO. I can also imagine that the "pure" freezing/melting/... processes could live in REX and that their environmental manifestations could reside in ENVO; however, this sounds too Platonic and, remembering my chemistry days, we know that there is no pure substance to freeze/melt/etc. (supporting ENVO as the home for bulk processes like these) |
pbuttigieg
added the
enhancement
label
Mar 28, 2017
pbuttigieg
assigned pbuttigieg and kaiiam
Mar 28, 2017
pbuttigieg
referenced
this issue
Mar 28, 2017
Closed
Reconcile environmental materials with CHEBI mixture branch #456
kaiiam
added a commit
to kaiiam/envo
that referenced
this issue
Mar 28, 2017
|
|
kaiiam |
14099a9
|
kaiiam commentedMar 27, 2017
•
edited
Hey @pbuttigieg ENVO needs some more basic physical processes: Here a few we should add:
phase transition process ref
freezing ref
melting ref
depositional phase change ref
vaporisation ref
condensation ref
sublimation ref
compaction or compaction process
material accumulation process
material transport process