Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Prepping pull request 3 for project cryophile #483
Comments
This was referenced Mar 31, 2017
|
Hi @kaiiam - this seems to be a normal issue and not a PR. Could you validate? [Edit: issue title updated to reflect it's not a confusion] Other comments below:
Not sure this works, the basin is actually a topological conformation of the crust. Perhaps we can use
[...]
Please add a comment here briefly describing on how the sediment is formed/transported (e.g. particles formed in the water column or transported by rivers or wind) and that it originates at the surface.
As above, add a comment on formation/transport processes, noting that this sediment type has more terrestrial inputs than deep sediments. [....]
This may not be right - this implies that every portion of shallow marine sediment is adjacent to the shelf or slope, which isn't the case (you could have sediment on top of sediment or sediment in the lab). I think we should defer this until we add sedimentation processes so we can then say it was the output of a sedimentation process that occurred in a neritic biome, or similar. This should be noted in a comment.
Not sure about |
pbuttigieg
changed the title from
Project cryophile Pull request 3 to Prepping pull request 3 for project cryophile
Mar 31, 2017
|
@pbuttigieg in response: for geographic basin I've changed the subclass axiom to
for your comments on sediment. It should by definition result form a transport process. So we'll make sedimentation process (subclass of precipitation process)
sediment transport process (subclass of material transport process)
for supraglacial lake: we could axiom relaxed to either 'depends on' or 'adjacent to' thoughts? |
Careful here, if they're in suspension they can't fall (strictly speaking)
I think this is enough, but I'd move the second sentence to a comment. |
|
@pbuttigieg more terms from #475 to add to this PR. ice ablation zone ref
with subclass axiom:
cryoconite ref
cryoconite holes ref
next we add glacial lake synonym tarn ref1, ref2 and we can encode the methane escaping lakes: |
pbuttigieg
added axiomatization enhancement
labels
Mar 31, 2017
This could be very interestingly axiomatised. @ramonawalls this is a good chance to enliven/close the issue on microbial community over at PCO PopulationAndCommunityOntology/pco#22
Good, but do mention melting processes in the def and axioms. |
Mention that it forms through melting and link with axioms. Take a look at RO's process axioms to find a good one.
Def. appears to be missing
Why continuous? Does meltwater have erosional force itself?
Cool, but go with "methane-releasing lake" |
pbuttigieg
added
to In Progress in cryophile
Mar 31, 2017
|
After some deliberation with @pbuttigieg about sedimentation process:
with subclass axioms:
|
|
Hi @kaiiam, we should label this "sedimentation in a water body" for absolute clarity |
Continued from #475brine channel:
seawater freezing process def:
brine rejection process def:
brine channel formation process def:
frazil def:
frazil formation def:
comment: Frazil formation constitutes an initial developmental stage of sea ice growth. |
kaiiam
added a commit
to kaiiam/envo
that referenced
this issue
Mar 31, 2017
|
|
kaiiam |
f144d1c
|
|
@pbuttigieg I've taken care of almost all of this. The remainder will continue in #487 |
kaiiam
closed this
Apr 4, 2017
kaiiam
added a commit
to kaiiam/envo
that referenced
this issue
Apr 5, 2017
|
|
kaiiam |
b0c253e
|
kaiiam commentedMar 31, 2017
•
edited
from #476
In last pull request I added geographic basin
In response to @pbuttigieg:
I've added the subclass axiom:
from #482
@mschecht addressing @pbuttigieg's concerns:
To sediment I added the comment:
I renamed marine sediment to deep marine sediment
changed: has_exact_synonym pelagic sediment to has_related_synonym pelagic sediment
def changed to:
added Class marine sediment (super class to deep marine sediment):
added class: shallow marine sediment
with has_related_synonym neritic marine sediment
I also added subclass axiom:
'adjacent to' some ('continental shelf' or 'continental slope')
from #475
I've added:
supraglacial lake
as far as I can tell by definition these lakes are strictly located in a glacier so I added the subclass axiom: