Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
project cryophile pull request 3 #483 #487
Conversation
pbuttigieg
requested changes
Apr 2, 2017
A good set of contributions for project cryophile, however, in need of some minor adjustments before merging is possible.
| @@ -28119,6 +28142,155 @@ SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03000032> <http://purl.obolibrar | ||
| SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03000032> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0000057> <http://purl.obolibrary.org/obo/ENVO_00000298>)) | ||
| SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03000032> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0002234> <http://purl.obolibrary.org/obo/ENVO_01000293>)) | ||
| +# Class: <http://purl.obolibrary.org/obo/ENVO_03000033> (marine sediment) | ||
| + | ||
| +AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://en.wikipedia.org/wiki/Pelagic_sediment#_note-8") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03000033> "Sediment which accumulates within an ocean basin.") |
pbuttigieg
Apr 2, 2017
Owner
I'd be a little more clear here, stating that this is sediment which was either formed in the marine water column or which was transported to and sedimented through the marine water column. Axiomatise as appropriate.
We must be a bit careful with "basin" as physical geographers sometimes consider any basin below sea level to be ocean basins, regardless of the presence of water.
kaiiam
Apr 3, 2017
•
Contributor
@pbuttigieg drawing upon the Dr. Bach's marine geology lectures on the I will refine the definition to:
Sediment sourced from either terrestrial systems, marine organisms, seawater and or cosmogeneous sources, which is transported through the marine water column, accumulating upon a marine ocean basin or seafloor.
With subclass axioms:
'has participant' some 'marine water body'
'output of' some 'sedimentation in a water body'
pbuttigieg
Apr 3, 2017
•
Owner
A material entity can't have a participant, that's for processes.
Also, rephrase:
Definition: Sediment which has been transported through the marine water column, settling on the seafloor.
Comment: Particles of marine sediment are primarily generated by 1) processes in terrestrial systems and transported to the marine realm by the action of rivers or aeolian processes (amongst other routes) , 2) marine organisms, 3) chemical processes in seawater, or 4) cosmogeneous input.
kaiiam
Apr 3, 2017
Contributor
@pbuttigieg I'm updating the definition and adding the comment. and changing the subclass axiom to:
'adjacent to' some 'marine water body'
| + | ||
| +# Class: <http://purl.obolibrary.org/obo/ENVO_03000034> (shallow marine sediment) | ||
| + | ||
| +AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://en.wikipedia.org/wiki/Continental_shelf") Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://en.wikipedia.org/wiki/Pelagic_sediment#_note-8") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03000034> "Marine sediment which accumulates within shallow regions of the oceanic basin close to continents, such as the continental shelf, or continental slope.") |
pbuttigieg
Apr 2, 2017
Owner
As above, rephrase def to say that the sediment was either formed or transported through the marine water column during its formation. This will be more in line with your comments/editor notes.
kaiiam
Apr 3, 2017
•
Contributor
@pbuttigieg definition revised to:
Marine sediment soured from either terrestrial systems, marine organisms, seawater and or cosmogeneous sources, which is transported through the marine water column, and accumulates within shallow regions of the oceanic basin close to continents, such as the continental shelf, or continental slope.
with subclass axiom:
'adjacent to' some ('continental shelf' or 'continental shelf')
pbuttigieg
Apr 3, 2017
Owner
Isn't occurs in reserved for processes? Always check the domain and range.
You could say (for marine sediments in geneal)
'output of' some ('sedimentation process' and 'occurs in' some 'marine water column')
Rephrase:
Marine sediment which has accumulated above the continental margins of an oceanic basin.
I've removed the "shallow" modifier and anchored to the features themselves. This won't be satisfactory for all. Please add an editor note saying that classes reflecting alternative definitions should be considered.
You don't need to add so much detail as the superclass contains it. You can copy the comment suggested in #487 (comment).
Do we have continental margin? The union of the shelf, slope, and rise?
| +SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03000036> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0000057> <http://purl.obolibrary.org/obo/ENVO_01000060>)) | ||
| +SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03000036> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0002229> <http://purl.obolibrary.org/obo/ENVO_03000010>)) | ||
| + | ||
| +# Class: <http://purl.obolibrary.org/obo/ENVO_03000037> (ice ablation zone) |
pbuttigieg
Apr 2, 2017
Owner
Please add a comment here saying that "zones" will likely be aligned to BFO:site and thus "occurs in" relations can be used.
kaiiam
Apr 3, 2017
Contributor
@pbuttigieg I added editors note:
Note: "zones" will likely be aligned to BFO:site and thus "occurs in" relations can be used.
| + | ||
| +# Class: <http://purl.obolibrary.org/obo/ENVO_03000038> (cryoconite) | ||
| + | ||
| +AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "http://www.nature.com/nrmicro/journal/v13/n11/full/nrmicro3522.html") Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://en.wikipedia.org/wiki/Cryoconite") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03000038> "Particulate matter including dust, rock, soot, and microorganisms deposited on an ice mass by an aeolian process.") |
pbuttigieg
Apr 2, 2017
Owner
I suppose microbes are particulate matter, in a sense; however, I think that the def can be rephrased to:
Particulate matter which is composed primarily of dust, rock, and soot, as well as the microbial communities associated with these materials, deposited on an ice mass by an aeolian process.
Further, in the subject matter you've parsed, @kaiiam, are the microbes always a necessary part of cryoconite?
kaiiam
Apr 3, 2017
•
Contributor
@pbuttigieg definition updated.
as for microbes being essential for cryoconite, it seems that microbes a part of the cryoconite mixture. Microbes seem to be an essential part of the cryoconite mixture.
| + | ||
| +# Class: <http://purl.obolibrary.org/obo/ENVO_03000039> (cryoconite hole) | ||
| + | ||
| +AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "http://glaciers.pdx.edu/Projects/Antarctica/CryoconiteHoles/Cryo_main.html") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03000039> "A vertical hole within an ice mass, formed by ice melt associated with local temperature increases, due to increased absorption of solar radiation by cryoconite deposits.") |
pbuttigieg
Apr 2, 2017
Owner
Minor rephrasing:
A depression or hole which forms vertically within an ice mass due to melting caused by the localised temperature increases brought about by increased absorption of solar radiation by cryoconite deposits relative to the surrounding ice and/or snow.
Is there a class for vertical anywhere? If not, we should queue that for ENVO spatial semantics ( xref #449 ). Could you make an issue for vertical and horizontal?
| + | ||
| +# Class: <http://purl.obolibrary.org/obo/ENVO_03000040> (melt pond) | ||
| + | ||
| +AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://en.wikipedia.org/wiki/Melt_pond") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03000040> "A small water body, which forms via a melting processes occuring within a continuous mass of ice such a glacier or on sea ice.") |
pbuttigieg
Apr 2, 2017
Owner
Rephrasing and corrections:
A water body which forms as a result of localised melting taking place on the surface of a glacier or a mass of sea ice and is typically contained in the cavity formed by that melting.
Please check if we can upgrade our representation of ice floes. We can queue that for the next PR.
Please also add open meltpond and closed meltpond as subclasses.
I think we can/should leave out the 'small' modifier as the size of the ice mass will constrain the size of the melt pond; however, the point at which a melt pond becomes an intraglacial lake would be interesting to explore. Is it just size or are there other differentiae? Please note this issue in a comment if you can't find clear information here.
pbuttigieg
Apr 2, 2017
Owner
PS: Is this in envoPolar? It should be if not - please do a sweep through our recent terms and legacy terms, adding the envoPolar subset ID as needed.
kaiiam
Apr 3, 2017
•
Contributor
@pbuttigieg I update the definition for this PR.
I'm adding the class: open melt pond with the def =
An open, atmosphere exposed, water body which forms as a result of localised melting taking place on the surface of a glacier or a mass of sea ice, contained in the open cavity formed by that melting.
closed melt pond def =
An enclosed, non-atmosphere exposed, water body which forms as a result of localised melting taking place within a glacier or a mass of sea ice, contained in the cavity formed by that melting.
Also I think I can finally use the located in axiom for closed melt ponds
'located in' some 'ice mass'
I've created an issue to addres continuum between melt pond and intraglacial lakes #489
finally before I submit this PR, I will make sure to add the envoPolar subset ID to terms which belong in polarOn
jzrapp
Apr 3, 2017
@kaiiam just reading through some of your entries here! cool!
I do, however, not agree with your definition of open vs closed ponds. or maybe we are referring to different things... when I use this term in my work "open" refers to being open to the underlying water column, while "closed" refers to being fully closed and therefore not directly connected to seawater. this has implications on salinity, temperature and of course species exchange. sometimes ponds can be "open", but still refreeze on the surface. They are then closed to the atmosphere, but still open to the seawater... maybe have a look at http://tos.org/oceanography/article/holes-in-progressively-thinning-arctic-sea-ice-lead-to-new-ice-algae-habita and references therein.
jzrapp
Apr 3, 2017
@kaiiam @pbuttigieg referring to my comment above: maybe this is different for glacial and sea-ice ponds?
kaiiam
Apr 3, 2017
•
Contributor
@jzrapp I was referring to glaciers or sea ice masses when I found these definitions. I will, however, take a look at the paper you suggested and see if I can refine the definitions. It would be most appreciate if you could comment again after I make some changes, or if you have time, on any of my other terms.
pbuttigieg
Apr 3, 2017
Owner
open melt pond def =
An open, atmosphere exposed, water body which forms as a result of localised melting taking place on the surface of a glacier or a mass of sea ice, contained in the open cavity formed by that melting.
Isn't much of this covered in the melt pond definition? No need to repeat material unless it's vital for understanding the def.
Also, rephrase to match the form: "A melt pond which ... "
Considering @jzrapp's input (which includes defs I've also seem before), perhaps create specific classes to accommodate all cases:
meltpond
- atmosphere-exposed meltpond
- meltpond channel (this would be a meltpond that is exposed to the atmosphere and the water column)
- ice-encased meltpond (totally sealed)
@jzrapp when you say:
while "closed" refers to being fully closed
Does this include being closed to the atmosphere and marine water?
closed melt pond def =
An enclosed, non-atmosphere exposed, water body which forms as a result of localised melting taking place within a glacier or a mass of sea ice, contained in the cavity formed by that melting.
As above, use the "A melt pond which ... " form (genus, differentiae):
Def: A melt pond which is encased in ice and thus not directly exposed to the atmosphere.
Comment: In practice, there may be some openings which are small relative to the surface footprint of the meltpond.
Also I think I can finally use the located in axiom for closed melt ponds
'located in' some 'ice mass'
Yes, I think this actually works here.
I've created an issue to addres continuum between melt pond and intraglacial lakes #489
Thanks!
finally before I submit this PR, I will make sure to add the envoPolar subset ID to terms which belong in polarOn
Great, thanks. I'll edit the Makefile to generate the new subset when your PR is in.
jzrapp
Apr 3, 2017
@pbuttigieg no, by closed I just refer to the connection to seawater. it can be in or without direct connection to the atmosphere.
| + | ||
| +# Class: <http://purl.obolibrary.org/obo/ENVO_03000042> (brine channel formation process) | ||
| + | ||
| +AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://nsidc.org/cryosphere/glossary/term/frazil") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03000042> "A material accumulation process during which trapped brine droplets, between ice crystals formed during seawater freezing, form brine channels.") |
pbuttigieg
Apr 2, 2017
Owner
It's interesting to see this as a material accumulation process. A comment explaining why brine is accumulating in this way would be useful
Rephrasing:
A material accumulation process during which brine droplets, trapped between ice crystals formed during seawater freezing, form brine channels.
kaiiam
Apr 3, 2017
•
Contributor
@pbuttigieg I thought a bit about it, brine channel formation process could either be a material transformation process or a material accumulation process, I think the latter is more useful. It's true that brine water results from the transformation of ice into meltwater with salt, but it's more useful to think of it as the brine water accumulating within places that would otherwise be a solid ice mass. I've added the following comment to make it more clear.
A brine channel formation process can be considered a material accumulation process because brine accumulates due to a brine rejection process, a material transformation process during which brine is formed due to the expulsion of salt during a seawater freezing process. This results in an accumulation of brine droplets, which are droplets of expelled salt dissolved in water, which remain in a liquid state due to their increased salinity.
To axiomatize this relationship I added to brine channel formation process the subclass axiom:
'preceded by' some 'brine rejection process'
| + | ||
| +# Class: <http://purl.obolibrary.org/obo/ENVO_03000043> (material transformation process) | ||
| + | ||
| +AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03000043> "A process during which the one or more materials, present within a given site, transform into another one or more materials.") |
pbuttigieg
Apr 2, 2017
Owner
Unlike accumulation, we don't need to refer to sites here as we're dealing with quanta of some material(s)
Thus:
A process during which a portion of some environmental material is converted into a different material or a collection of materials.
Also, add a comment stressing we're talking about ENVO:environmental material here (e.g. bulk and typically impure substances), rather than things like the conversion of a specific chemical into another. The latter case belongs in the CHEBI/REX realm.
kaiiam
Apr 3, 2017
•
Contributor
@pbuttigieg I've taken your definiton.
I've added comment:
A material transformation process only refers to ENVO:environmental material classes (e.g. bulk and typically impure substances), rather than transformations converting a specific chemical into another.
editors note:
A different material transformation process class (or similarly named class) pertaining to the conversion of a specific chemical into another belongs in CHEBI and or REX ontologies.
| +AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000117> <http://purl.obolibrary.org/obo/ENVO_03000044> "http://orcid.org/0000-0002-3410-4655") | ||
| +AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_03000044> "seawater freezing process"@en) | ||
| +SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03000044> <http://purl.obolibrary.org/obo/ENVO_03000043>) | ||
| +SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03000044> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0000057> <http://purl.obolibrary.org/obo/ENVO_00002149>)) |
| + | ||
| +# Class: <http://purl.obolibrary.org/obo/ENVO_03000045> (brine rejection process) | ||
| + | ||
| +AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://en.wikipedia.org/wiki/Brine_rejection") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03000045> "A material transformation process during which brine is formed due to the expulsion of salt during frazil formation or a seawater freezing process. Expelled salt accumulates in brine droplets, which remain in a liquid state due to their increased salinity.") |
kaiiam
Apr 3, 2017
Contributor
@pbuttigieg broke second sentence of definition into a comment.
Def =
A material transformation process during which brine is formed due to the expulsion of salt during frazil formation or a seawater freezing process.
comment:
Expelled salt accumulates in brine droplets, which remain in a liquid state due to their increased salinity.
| + | ||
| +AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://en.wikipedia.org/wiki/Brine_rejection") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03000045> "A material transformation process during which brine is formed due to the expulsion of salt during frazil formation or a seawater freezing process. Expelled salt accumulates in brine droplets, which remain in a liquid state due to their increased salinity.") | ||
| +AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000117> <http://purl.obolibrary.org/obo/ENVO_03000045> "http://orcid.org/0000-0002-3410-4655") | ||
| +AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_03000045> "brine rejection process"@en) |
kaiiam
Apr 3, 2017
•
Contributor
Yes, it is, the label: brine rejection process is being updated to brine rejection from seawater
Also the axiom in brine channel formation process is being updated to:
'preceded by' some 'brine rejection from seawater'
| +AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000117> <http://purl.obolibrary.org/obo/ENVO_03000045> "http://orcid.org/0000-0002-3410-4655") | ||
| +AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_03000045> "brine rejection process"@en) | ||
| +SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03000045> <http://purl.obolibrary.org/obo/ENVO_03000043>) | ||
| +SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03000045> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0000057> <http://purl.obolibrary.org/obo/ENVO_00002149>)) |
kaiiam
Apr 3, 2017
•
Contributor
@pbuttigieg the subclass axiom is being changed to:
'has input' some 'sea water'
| + | ||
| +# Class: <http://purl.obolibrary.org/obo/ENVO_03000046> (frazil) | ||
| + | ||
| +AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://nsidc.org/cryosphere/glossary/term/frazil") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03000046> "Small needle-like ice crystals consisting of nearly pure fresh water, which are suspended in water.") |
pbuttigieg
Apr 2, 2017
Owner
Ice which is composed of small, needle-like crystals consisting of nearly pure fresh water, which are suspended in water
This leads to the question: is frazil just the ice part of this mixture, or the water too?
To be less ambiguous, I'd label this frazil ice and use the surrounded by relation to seawater.
Please make an editor note saying that this should be connected to the semantics of colloids and suspensions once this PATO issue is addressed
Not a fan of the "small" here: is there no physical property we can anchor this to?
kaiiam
Apr 3, 2017
•
Contributor
@pbuttigieg I'll update the label to frazil ice,
Update to your definition:
Ice which is composed of small, needle-like crystals consisting of nearly pure fresh water, which are suspended in water
I'll add the subclass axiom:
'surrounded by' some 'sea water'
editors note:
Needs to have axioms added pertaining to the semantics of colloids and suspensions once they have been resolved see pato-ontology/pato#91 (comment)
kaiiam
Apr 3, 2017
Contributor
@pbuttigieg I know you don't like the usage of small but NSIDC explicitly states so and it gives a size range which I'll add as a comment:
Typically 3 to 4 millimeters in diameter.
So I think we can leave small in the definition. Unless you really don't want it or the comment to be there.
Like we did for cirque glacier, I'll add subclass axiom:
'has quality' some 'decreased size'
| + | ||
| +# Class: <http://purl.obolibrary.org/obo/ENVO_03000047> (frazil formation) | ||
| + | ||
| +AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://nsidc.org/cryosphere/glossary/term/frazil") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03000047> "A material accumulation process in which frazil ice crystals merge, forming thin sheets of ice.") |
pbuttigieg
Apr 2, 2017
Owner
This doesn't sound like a def for the formation of frazil, but for the transformation of frazil ice into a more continuous and consolidated form of ice.
kaiiam
Apr 3, 2017
•
Contributor
@pbuttigieg you're right. I'll change the label and definition to:
frazil ice formation: def = An ice formation process in which frazil ice crystals form due to the freezing of open, turbulent, supercooled water.
with subclass axioms:
'has input' some 'water mass'
'has output' some 'frazil ice'
We now need a new set of classes to describe the various steps in the transition processes between frozen water and sea ice as subclasses of a sea ice formation process Here are additional classes to be added in order to encapsulate the process of sea ice formation, as well as some other important ice terms:
The overall process of sea ice formation proceeds as a continuum from seawater -> new ice -> nilas -> young ice -> first year ice -> second year ice -> multiyear ice.
Within the occurrent hierarchy, I'll add:
material transformation process:
- ice formation process def = A material transformation process during which water is frozen into water ice.
-- new ice formation process def = An ice formation process during which water is frozen into a form of new ice such as frazil, grease ice, slush, or shuga.
-- sea ice formation process def = An ice formation process during which seawater is frozen into a sea ice floe.
--- nilas formation process source1 & source2 def = A sea ice formation process during which new ice such as frazil ice crystals freeze together, forming nilas, a thin, elastic, continuous, ice sheet of a transparent gray color.
--- young ice formation process def = A sea ice formation process during which water freezes to the bottom of an existing nilas ice floe creating a thicker ice floe known as young ice.
--- first year ice formation process def = A sea ice formation process during which seawater freezes onto young ice during the cold season.
comment: first year ice does not survive the spring and summer months due to melting.
--- second year ice formation: def = A sea ice formation process during which seawater freezes onto first year ice during the cold season, and in which the ice floe has previously survived one melt season.
--- multiyear ice formation process def = A sea ice formation process during which seawater freezes onto second year ice during the cold season, and the ice floe has previously survived more then two melt seasons.
Then within the environmental material hierarchy I'll add the following classes:
water ice
-new ice def = Water ice which is formed from freezing water during a new ice formation process and is suspended in a water body.
Comment: sea ice types include frazil, grease ice, slush, and shuga.
-- shuga source1 source2 def = Spongy, lumpy and opaque new ice, which forms during a water freezing in an agitated water body.
-- frazil ice def = New ice which is composed of small, needle-like crystals consisting of nearly pure fresh water.
note to myself as editor: I need to add subclass axiom to also make it subset of new ice, as it is currently only a subset of water ice crystal.
--- grease ice def = A thin, layer of frazil ice crystals which clump together.
comment: Within a marine system, grease ice makes the ocean surface resemble an oil slick.
---- slush ice def = Grease ice which is mixed with snow.
-ice floe def = A cohesive sheet of water ice which floats upon the surface of a water body.
comment: Ice floes can exist in sea ice, in rivers or lakes.
-- sea ice floe def = An ice floe which is formed from frozen sea water, and floats upon the surface of a marine water body
--- pancake ice source1 source2 def = A sea ice floe which has a rounded or circular shape and raised rims.
--- nilas source1 source2 source3 def = A thin, elastic, continuous, sea ice floe of a transparent gray color, which results from the freezing of seawater during a nilas formation process.
comment: Nilas is characterized by a matte surface, and is easily bent by waves which can thrust it into a pattern of interlocking fingers.
--- young ice def = An inflexible sea ice floe, thicker then nilas which is formed during a young ice formation process.
Comment: Young ice is not as flexible as nilas, but tends to break under wave action. In a compression regime, it will either raft (at the gray ice stage) or ridge (at the gray-white ice stage).
--- first year ice source 1 source2 = A sea ice floe thicker then young ice, which results from a first year ice formation process.
Comment: Forms from water freezing on to the bottom of the existing ice sheet, a process called congelation growth. First year ice does not survive a full melt season as it is melted away.
--- second year ice def = A sea ice floe thicker then first year ice, which results from a second year ice formation process.
comment: Second year ice has survived melting during a full melt season.
--- multiyear ice def = A sea ice floe thicker then second year ice, which results from a multiyear ice formation process.
comment: Multiyear ice has survived melting during more then two full melt seasons.
pbuttigieg
Apr 5, 2017
Owner
frazil ice formation: def = An ice formation process in which frazil ice crystals form due to the freezing of open, turbulent, supercooled water.
with subclass axioms:
'has input' some 'water mass'
'has output' some 'frazil ice'
The input should probably be water (a material), otherwise it's looking good.
We now need a new set of classes to describe the various steps in the transition processes between frozen water and sea ice as subclasses of a sea ice formation process Here are additional classes to be added in order to encapsulate the process of sea ice formation, as well as some other important ice terms:
Wow! this is enough for another PR, but let's give it a shot:
The overall process of sea ice formation proceeds as a continuum from seawater -> new ice -> nilas -> young ice -> first year ice -> second year ice -> multiyear ice.
Makes sense. This may be a place for some of the causal relations from RO.
Within the occurrent hierarchy, I'll add:
material transformation process:
ice formation process def = A material transformation process during which water is frozen into water ice.
Would we not include depositional processes here? That is, water vapour deposited as water ice?
-- new ice formation process def = An ice formation process during which water is frozen into a form of new ice such as frazil, grease ice, slush, or shuga.
This could then be a union class of 3 processes:
- frazil formation process
- grease ice formation process
- slush formation process
- shuga formation process
You can make an equivalence axiom like
`'ice formation process' and 'has output' some ('frazil ice' or 'grease ice' or 'slush ice' or 'shuga')
-- sea ice formation process def = An ice formation process during which seawater is frozen into a sea ice floe.
Hmm, does it have to be a sea ice floe? I'd prefer that the output is 'sea ice' as it may not be in the form of a floe at the early stages.
--- nilas formation process def = A sea ice formation process during which new ice such as frazil ice crystals freeze together, forming nilas, a thin, elastic, continuous, ice sheet of a transparent gray color.
We could make a union class for new ice and then remove the "such as' bit from this def. That means we'd have an equivalence axiom for new ice:
ice and 'composed primarily of' some ('frazil ice' or 'grease ice' or 'slush ice' or shuga)
We could then add the following subclass axioms for nilas formation process:
'has input' some 'new ice'
'has output' some nilas
--- young ice formation process def = A sea ice formation process during which water freezes to the bottom of an existing nilas ice floe creating a thicker ice floe known as young ice.
Is there a clear threshold where nilas becomes new ice? When it loses its transparency?
Note that PATO has transparent, please add this to our imports if its not there already.
--- first year ice formation process def = A sea ice formation process during which seawater freezes onto young ice during the cold season.
comment: first year ice does not survive the spring and summer months due to melting.
Not sure about the comment here - surely some first year ice survives to be second year ice? the definition sounds more appropriate for "one year ice" and even then, it doesn't survive the whole year, just the cold seasons. Perhaps "seasonal ice" is a more appropriate label for the ice type this process refers to.
first year ice would be ice that endures for one complete seasonal cycle of a planet or similar astronomical body.
--- second year ice formation: def = A sea ice formation process during which seawater freezes onto first year ice during the cold season, and in which the ice floe has previously survived one melt season.
This would make more sense if the semantics for first year ice are updated as suggested above: if first year ice melts away in spring and summer, second year ice would never form. Once again, I'd leave out the ice floe in this def as this ice type need not be part of one.
--- multiyear ice formation process def = A sea ice formation process during which seawater freezes onto second year ice during the cold season, and the ice floe has previously survived more then two melt seasons.
The second part of this definition (",and the ice floe...") is not needed as this is bundled in with second year ice.
Then within the environmental material hierarchy I'll add the following classes:
[...]
-new ice def = Water ice which is formed from freezing water during a new ice formation process and is suspended in a water body.Comment: sea ice types include frazil, grease ice, slush, and shuga.
Make sure to axiomatise as suggested above.
-- shuga def = Spongy, lumpy and opaque new ice, which forms during a water freezing in an agitated water body.
Rephrase to:
Ice which is formed through the freezing of water in an agitated water body, conferring it spongy, lumpy, and opaque properties.
-- frazil ice def = New ice which is composed of small, needle-like crystals consisting of nearly pure fresh water.
note to myself as editor: I need to add subclass axiom to also make it subset of new ice, as it is currently only a subset of water ice crystal.
It can't be a subclass of water ice crystal as that's countable and thus not a material. Also, if we make new ice a union class, we don't need to make the various kinds of new ice subclasses (the reasoner will do that). We'd just have them as subclasses of water ice.
--- grease ice def = A thin, layer of frazil ice crystals which clump together.
comment: Within a marine system, grease ice makes the ocean surface resemble an oil slick.
This is a bit tricky: if grease ice is made up of frazil ice (that is, the frazil ice hasn't been altered) then maybe this isn't a material but a grease ice layer (subclass of layer).
---- slush ice def = Grease ice which is mixed with snow.
We'll get back to this once we figure out grease ice.
-ice floe def = A cohesive sheet of water ice which floats upon the surface of a water body.
comment: Ice floes can exist in sea ice, in rivers or lakes.
Axiomatise appropriately with 'composed primarily of' some 'water ice' etc
-- sea ice floe def = An ice floe which is formed from frozen sea water, and floats upon the surface of a marine water body
Axiomatise appropriately with output of and composed primarily of etc
--- pancake ice def = A sea ice floe which has a rounded or circular shape and raised rims.
Are there any PATO qualities we can use here to express these shapes? If not, we should request them.
--- nilas def = A thin, elastic, continuous, sea ice floe of a transparent gray color, which results from the freezing of seawater during a nilas formation process.
I'd drop the process part in the def, the process should have subclass axiom has output some nilas.
Also, transparent is not a colour property, so rephrase that. Again, check PATO for quality classes and request new ones if needed.
--- young ice def = An inflexible sea ice floe, thicker then nilas which is formed during a young ice formation process.
Again, we can drop the process part of this def. Check PATO for inflexible or similar.
Comment: Young ice is not as flexible as nilas, but tends to break under wave action. In a compression regime, it will either raft (at the gray ice stage) or ridge (at the gray-white ice stage).
Here you contradict the def - if something is inflexible it can't be 'not as flexible' as something else. It would be interesting to have the rafting and ridging processes in the next PR. Perhaps we can create issues for these.
--- first year ice = A sea ice floe thicker then young ice, which results from a first year ice formation process.
then --> than
Also, while this ice type does occur in floes, I'm not sure that's necessary (it's also not a subclass of sea ice floe if it's in the material hierarchy).
Here's a good example of where some of the info from the process def would be useful: Incorporate some to give users an idea of what seasonal fluctuations this ice has been subject to.
Comment: Forms from water freezing on to the bottom of the existing ice sheet, a process called congelation growth. First year ice does not survive a full melt season as it is melted away.
Again, this doesn't make sense or there would be no second year ice. This suggests we need seasonal ice and first year ice as separate categories as noted above. If existing glossaries don't differentiate between them, we should synonymise and add editor notes explaining why.
--- second year ice def = A sea ice floe thicker then first year ice, which results from a second year ice formation process.
comment: Second year ice has survived melting during a full melt season.
This can't be an ice floe, as explained above.
A bit more description in the def would be useful, just noting that it endured one melt season.
--- multiyear ice def = A sea ice floe thicker then second year ice, which results from a multiyear ice formation process.
comment: Multiyear ice has survived melting during more then two full melt seasons.
This can't be an ice floe. Same issues with the def as above. The comment material should probably be integrated with the def.
kaiiam
Apr 6, 2017
•
Contributor
@pbuttigieg I'll add:
depositional process def =
A process during which material entities are added to a landform or to a feature upon the landform.
ice formation process def =
A depositional process during which water vapour is frozen into water ice.
For new ice formation process I'll add the editors note:
Make this class the union of the following processes: frazil ice formation, slush formation process, and shuga formation process.
I will add the subclass axiom:
'has output' some ('frazil ice' or 'slush ice' or shuga)
slush formation process def =
A new ice formation process in which slush ice is formed.
subclass axioms:
'has input' some (water and snow and 'frazil ice')
'has output' some 'slush ice'
shuga formation process def =
A new ice formation process in which shuga is formed.
subclass axioms:
'has input' some water
'has output' some shuga
I will add sea ice formation process as:
An ice formation process during which seawater is frozen into a sea ice.
with subclass axioms:
'has input' some 'sea water'
'has output' some 'sea ice'
for nilas formation process: I'm not sure how to make it a union class with new ice but what I'll do is make the definition:
A sea ice formation process during which new ice crystals freeze together, forming nilas, a thin, elastic, continuous, ice sheet of a transparent gray color.
Then to new ice, we add the subclass axiom:
'composed primarily of' some ('frazil ice' or 'slush ice' or shuga)
@pbuttigieg asked me to:
please add PATO has transparent to our imports if its not there already.
for young ice formation process: add subclass axiom:
'has output' some 'young ice'
'has input' some ('sea water' and nilas)
for first year ice formation process, I'll change the comment to:
First year ice that survives melting during spring and summer can transition to second year ice.
Also I'll change the definition to:
A sea ice formation process during which seawater freezes onto young ice during the cold season, forming first year ice.
subclass axiom:
'has input' some ('sea water' and 'young ice')
'has output' some 'first year ice'
second year ice formation:
A sea ice formation process during which seawater freezes onto first year ice during the cold season forming, second year sea ice.
multiyear ice formation process
A sea ice formation process during which seawater freezes into second year ice during the cold season, forming multiyear ice.
Comment:
Multiyear ice forms from second year ice which has previously survived at least two melt seasons.
subclass axioms:
'has input' some ('sea water' and 'second year ice')
'has output' some 'multiyear ice'
for new ice added subclass axioms:
'output of' some 'new ice formation process'
'adjacent to' some 'water body'
I have the class:
frazil ice def =
New ice which is composed of small, needle-like crystals consisting of nearly pure fresh water.
@pbuttigieg stated about frazil ice that:
It can't be a subclass of water ice crystal as that's countable and thus not a material. Also, if we make new ice a union class, we don't need to make the various kinds of new ice subclasses (the reasoner will do that). We'd just have them as subclasses of water ice.
So I will change frazil ice to be a subclass of new ice instead of water ice crystal
I'll add shuga as subclass of new ice:
New ice, which is spongy, lumpy and opaque, and forms from water which freezes in an agitated water body.
subclass axioms:
'has quality' some opaque
In respone to @pbuttigieg's comment about my definition for grease ice:
This is a bit tricky: if grease ice is made up of frazil ice (that is, the frazil ice hasn't been altered) then maybe this isn't a material but a grease ice layer (subclass of layer).
I'll make grease ice layer be a subclass of layer, def =
A layer which consists of a thin aggregate of frazil ice crystals, which float upon the surface of a water body.
comment:
Within a marine system, grease ice makes the ocean surface resemble an oil slick.
subclass axioms:
'has quality' some 'decreased thickness'
'adjacent to' some 'water body'
Since we run into a bit of a material vs layer issue for slush ice @pbuttigieg and I have decided we will have two difference classes: slush ice layer (subclass of layer) and slush (subclass of new ice)
slush ice layer def =
A layer which consists of slush ice.
subclass axioms:
'adjacent to' some 'water body'
'has part' some 'slush ice'
New ice which is a slurry mixture of frazil, snow and liquid water.
subclass axioms:
'has part' some 'frazil ice' and snow and water
for ice floe: I'll add the subclass axioms:
'composed primarily of' some 'water ice'
'adjacent to' some 'water body'
for sea ice floe: I'll add the subclass axioms:
'adjacent to' some 'marine water body'
'output of' some 'sea ice formation process'
In order to express the rounded shape of pancake ice I used the PATO circular in:
subclass axiom:
'has quality' some circular
nilas
A sea ice floe which is thin, elastic, continuous, and of a transparent gray color, which results from the freezing of new ice.
With subclass axioms:
'has input' some 'new ice'
'has output' some nilas
'has quality' some transparent
'has quality' some elastic
'has quality' some continuous
young ice
A sea ice floe which is inflexible and thicker then nilas.
subclass axioms:
'has quality' some inflexible
'has quality' some 'increased thickness'
first year ice:
Sea ice which is thicker than young ice.
subclass axioms:
sea ice
'output of' some 'first year ice formation process'
'has quality' some 'increased thickness'
Comment:
First year ice that survives a seasonal melting process becomes second year ice.
Still need to add a subclass axiom for seasonal melting process. //TODO for all the sea ice formation processes
@pbuttigieg Perhaps we can do a union between ice floe and sea ice instead of having the class sea ice floe. I'm not sure how to do this perhaps you can help me figure that out.
second year ice
Sea ice which is thicker than first year ice, and has survived a seasonal melting process.
subclass axioms:
sea ice
'output of' some 'second year ice formation'
'has quality' some 'increased thickness'
For second year ice formation:
A sea ice formation process during which seawater freezes onto first year ice during the cold season, forming second year sea ice.
comment:
Second year ice forms from first year ice which has previously survived one melt season.
subclass axiom:
'has input' some ('sea water' and 'first year ice')
'has output' some 'second year ice'
multiyear ice
Sea ice which is thicker then second year ice, and has survived more than two seasonal melting process.
subclass axiom:
sea ice
'has quality' some 'increased thickness'
'output of' some 'multiyear ice formation process'
@pbuttigieg it would be need to express the continuum between first year ice, second year ice and multiyear ice interms of thickness can we do that somehow?
| + | ||
| +# Class: <http://purl.obolibrary.org/obo/ENVO_03000048> (thaw hole) | ||
| + | ||
| +AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://nsidc.org/cryosphere/glossary-terms/sea-ice") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03000048> "vertical hole in floating ice formed when a puddle melts through to the underlying water.") |
pbuttigieg
Apr 2, 2017
Owner
This def needs work. Rephrasing should be done looking at the suggestion in this review for cryoconite hole. More importantly, is the puddle doing the melting? Do we have a class for floating ice? I know we have sea ice, but 'floating ice' may be useful as a superclass.
jzrapp
Apr 3, 2017
@pbuttigieg but is there any ice that wouldn't float? isn't that confusing? i would think it's just a matter of compression?
kaiiam
Apr 3, 2017
•
Contributor
Hey @pbuttigieg @jzrapp I think adding the fact sea ice floats on the ocean surface to the definition of sea ice address your concerns over the semantics of floating ice. I'm currently working on categorizing the various stages of sea ice development adding classes for new ice, nilas, young ice, and multiyear ice, all of which are to be subclasses of sea ice.
pbuttigieg
Apr 3, 2017
•
Owner
@jzrapp This is more to indicate that the ice is on top of some medium upon which it floats. It's subclasses will be, e.g., sea ice and lake ice. You're right that the label can be confusing, as it suggests non-floating ice is a sibling.
@kaiiam it also may split the hierarchy unnecessarily (floating being the differntia). I think we should just edit the def:
A hole which has formed through an ice mass floating on a water body, bridging the atmosphere to the underlying water.
We also have to relate this to channel semantics. Could you add an editor note to that effect and link it to relevant issues?
pbuttigieg
Apr 3, 2017
Owner
Also, given our review of #487 (comment), how is the thaw hole different from a melt pond channel? If they're the same, we could consider synonyms.
kaiiam
Apr 4, 2017
•
Contributor
Hey @pbuttigieg and @jzrapp continued from and, in response to #489 we have a discussion on how to differentiate between meltponds open and or closed to the atmosphere and or underlying water body, as well as at what point does a meltpond become an intraglacial lake.
In the hierarchy under water body we could add the following:
meltpond def =
A water body which forms as a result of localised melting taking place on the surface of a glacier or a mass of sea ice and is contained in the cavity formed by such melting.
- atmosphere-exposed meltpond: def =
A meltpond which is located toward the surface of an ice mass, exposed to the atmosphere but closed to the bottom of the ice mass or to any underlying water.
- thaw hole: def =
A vertical meltpond hole which has formed through an ice mass floating on a water body, bridging the atmosphere to the underlying water.
synonym: meltpond channel
- ice-encased meltpond: def =
A melt pond which is completely encased in ice and thus not directly exposed to the atmosphere or underlying water.
subclass axiom: 'located in' some 'ice mass'
Comment: In practice, there may be some openings which are small relative to the surface footprint of the meltpond.
As for intraglacial lakes they seem to be less commonly described in the literature, but what I could piece together is:
intraglacial lake source1 and source2 def =
A lake which is comprised of meltwater located underneath or within a glacier.
Although it's similar to an ice-encased meltpond it's probably larger and I don't think we currently have the axioms in ENVO to deal with that. I'll leave the editors note:
Add axioms to show that this is on the larger side in a size continuum between ice-encased meltponds and intraglacial lakes.
pbuttigieg
self-assigned this
Apr 3, 2017
This was referenced Apr 3, 2017
|
You can file a ticket for me to have the domains/ranges present so you'd
get this check directly in Protege and Travis-CI will flag these.
…
|
This was referenced Apr 4, 2017
From #483Here are the rest of the classes discussed earlier in #483 presented with their definitions and axioms: glacial lake def =
subclass axiom:
moraine def =
subclass axiom:
Here are some additional classes needed in order to encode methane-releasing lakes from this news article on bubbling blue arctic lakes. methane-releasing lake (subclass of thermokarst lake) def =
comment:
subclass axiom:
thermokarst lake def =
Comment:
synonyms:
sublcass axiom:
thermokarst depression def =
sublcass axiom:
thermokarst (subclass of environmental zone) def =
Comment:
subclass axioms:
Additional classes harvested from and pertaining to those in the bubbling blue arctic lakes report are:permafrost thawing process def =
methane-laden permafrost: source1 source2 def =
comment:
suclass axioms:
synonym
methane-sourced permafrost crater source1 source2 def =
subclass axioms:
Editors note:
methane laden permafrost explosion process: source1 source2 def =
suclass axioms:
explosion process: (subclass of environmental system process) def =
suclass axioms:
More global warming associated terms which could be useful: within the occurrent hierarchy:material transport process
suclass axioms:
-- hydrocarbon gas emission process def =
Comment:
subclass axiom:
--- methane gas emission process: def =
|
From #472@pbuttigieg in order to best response to your comments:
As well as drawing up the discussion from #253, I propose the following classes: To the occurent hierarchy we should add:season generating process: def =
Comment:
editors note:
subclass axioms:
I think season should be an occurent but if I'm wrong please let me know: season def =
subclass axioms:
-cold season
seasonal melting process def =
subclass axiom:
snowmelt def =
subclass axiom:
sintering def =
subclass axioms:
snow drifting def =
subclass axioms:
synonym:
avalanche def =
subclass axioms:
synonyms:
suclass axioms:
Comment:
suclass axioms:
synonym:
suclass axioms:
Comment:
I'll also add, as synonym of glacial transport process:
I also propose that we we move mass wasting process to be a subclass of material transport process. Next I propose we add the following classes to the material entity hierarchy:slab snow def =
subclass axiom:
snow drift def =
subclass axioms:
synonym:
snow patch def =
subclass axioms:
-seasonal snow patch def =
subclass axiom:
-perennial snow patch def =
snowpack def =
editors note:
Finally we could probably add as subclass axiom for snow:
|
pbuttigieg
added a commit
that referenced
this pull request
Apr 6, 2017
|
|
pbuttigieg |
9fa5ec8
|
Rephrasing:
Your use of 'during' was confusing. Add a subclass axiom: Remove:
Can this be related to ENVO: I'm not sure about the use of
Are they always thermokarst lakes? Can no other lake release methane? You can relable to "methane-releasing thermokarst lake" if you want to be clear.
Check the grammar around "microorganism" and add "in the light spectrum visible to humans" after appearance.
you can add adjacency to some atmosphere
Rephrase: A freshwater lake which fills a depression formed by the erosion of thermokarst caused by permafrost thaw. Subclass of ENVO: Is it mostly compsoed of meltwater? Axiomatise if so.
'formed as a result of' could point to permafrost thawing process rather than erosion. Does PFT jive with the definition of erosion we have currently?
This axiom is a bit tenous, I'd remove it for now.
As above, link to permafrost thawing rather than erosion.
Again, I'd remove this axiom
This wouldn't be a subclass of zone as zones will be moved to sites and a thermokarst is a material entity. We have
Remove the three causal axioms above. Link by adding the subclass axiom You could also state
axiomatise with
Please add an editor's note here saying that it would probably be better to assert parthood between the permafrost and cavities filled with gas rather than the gases themselves.
Watch the usage of "during".
Add a hyphen between "methane" and "laden".
Not really - they may not form a crater and are we not focused on methane here? We could say:
See if this fits under
Here I would say You can also list
Always?
I'd have this as a subclass of combustion process.
I'd say We have fuel, I'm importing oxidant now (merge the upstream with your master repo to access). Please create an issue for the semantics of explosions. we should be able to express energy release and volumetric changes in general, either in ENVO or REX.
Please reconcile this with ENVO:
gasses --> gas
Update to: We have hydrocarbon gas in the material hierarchy.
displaced --> transported |
pbuttigieg
added a commit
that referenced
this pull request
Apr 6, 2017
|
|
pbuttigieg |
31ca0c7
|
|
@pbuttigieg in response to your response to my comments I'm adding and or updating the following classes: I will update the definition of glacial lake def to:
with subclass axioms:
The class: moraine already exists with def =
I will add the wiki as dbxref, but I won't change the definition. I will add the subclass axiom:
in response to your comments:
According to the wiki regolith can include material transported by glacial, flow processes. It doesn't, however, seem to refer to moraine as being associated with regolith. Nor does moraine seem to have any links to regolith. So I think it's more that regolith may have erosional material deposited from from glacially enriched ice, but a moraine is not necessarily a subclass of regolith. I could loosen participants from being both rock and soil to either rock and or soil by adding the subclass axiom: ('has part' some rock and soil) or ('has part' some rock or soil) But I'm not sure if that would work or not, so I'm going to leave that out. I'll change methane-releasing lake to: methane-releasing thermokarst lake def =
comment:
subclass axioms:
I'll rephrase the definition of thermokarst lake to def =
Comment:
synonyms:
subclass axioms:
thermokarst depression def =
subclass axioms:
It would make sense to put thermokarst as subclass of karst. def =
I wish we could add the subclass axiom: thermokarst 'has part' some permafrost, but I'm not sure about this if the permafrost in an area completely disappears leaving behind thermokarst then that thermokarst wouldn't still have part permafrost. Instead I'll say 'formed as result of' some 'permafrost thawing process'. subclass axioms:
Comment:
permafrost thawing process def =
subclass axioms:
For methane-laden permafrost: source1 source2 def =
comment:
suclass axioms:
synonym
editors note:
methane-sourced permafrost crater source1 source2 def =
synonym = gigantic funnel subclass axioms:
Editors note:
I'll rename methane laden permafrost explosion process: to permafrost methane explosion source1 source2 def =
subclass axioms:
To the class combustion process, I'll add editors note:
explosion process def =
suclass axioms:
comment:
@pbuttigieg I have created an issue #495 asking to help better handle the semantics of explosions. Gas emissionsIn order to reconcile the gas emission hierarchy I propose the following: material transport process
suclass axioms:
-- hydrocarbon gas emission process def =
Comment:
subclass axiom:
--- methane gas emission process: def =
comment:
subclass axiom:
Then we can fit the classes carbon-bearing gas emission process and carbon dioxide emission process, into this hierarchy: ---carbon-bearing gas emission process subclass axioms:
----carbon dioxide emission process subclass axioms:
|
|
@kaiiam, below, find some input for the classes you moved over from #483
Rephrasing:
Your use of 'during' was confusing. Add a subclass axiom: Remove:
Can this be related to ENVO: I'm not sure about the use of
Are they always thermokarst lakes? Can no other lake release methane? You can relable to "methane-releasing thermokarst lake" if you want to be clear.
Check the grammar around "microorganism" and add "in the light spectrum visible to humans" after appearance.
you can add adjacency to some atmosphere
Rephrase: A freshwater lake which fills a depression formed by the erosion of thermokarst caused by permafrost thaw. Subclass of ENVO: Is it mostly compsoed of meltwater? Axiomatise if so.
'formed as a result of' could point to permafrost thawing process rather than erosion. Does PFT jive with the definition of erosion we have currently?
This axiom is a bit tenous, I'd remove it for now.
As above, link to permafrost thawing rather than erosion.
Again, I'd remove this axiom
This wouldn't be a subclass of zone as zones will be moved to sites and a thermokarst is a material entity. We have
Remove the three causal axioms above. Link by adding the subclass axiom You could also state
axiomatise with
Please add an editor's note here saying that it would probably be better to assert parthood between the permafrost and cavities filled with gas rather than the gases themselves.
Watch the usage of "during".
Add a hyphen between "methane" and "laden".
Not really - they may not form a crater and are we not focused on methane here? We could say:
See if this fits under
Here I would say You can also list
Always?
I'd have this as a subclass of combustion process.
I'd say We have fuel, I'm importing oxidant now (merge the upstream with your master repo to access). Please create an issue for the semantics of explosions. we should be able to express energy release and volumetric changes in general, either in ENVO or REX.
Please reconcile this with ENVO:
gasses --> gas
Update to: We have hydrocarbon gas in the material hierarchy.
displaced --> transported
Seasons are more a function of the Earth's tilt, so we should include that: Rephrase:
Rephrase:
Well, we are setting this up to have season as a temporal entity with fiat boundaries (which is an occurrent, I believe. This is new to ENVO, so we'll discuss this further, but I think it will be a subclass of one-dimensional temporal region. It will contain many processes.
This def references the generation process too much, try:
This will allow us to say things like "the rainy season was late".
This can't be satisfied as a process can't be the input for a temporal region.
Avoid the term "characterized" and get right to the differentia. Rephrase to:
I'm not linking this to the radiation, just in case the heat is transported through the planet's atmosphere or hydrosphere to an area with low radiation. Add a comment to this and all other seasons:
Similar to above:
Do we have a
If we have melting process, rephrase to:
You can go for
and or ---> and/or Also, because liquid phase sintering exists, let's label this as 'solid-phase sintering'. We can create superclasses and siblings later if needed. I think we can axiomatise like this: We should have PATO:porosity, but I don't think 'decreased porosity' exists. Please create an issue on the PATO tracker linking to this comment and an editor's note that this should be added if/when the PATO class becomes available. Again, if we could say material M1 has decreased porosity relative to M2, this would be much more useful. We can't say that the output is non-porous, as sintering does not need to remove all porosity. Make an editor's note that axioms could also refer to object aggregates becoming objects within an environmental material.
Add editor's note saying the axioms would probably need to be updated if the axiomatisation of sintering change.
Given that snow drifts are (also?) static, we would have to approach this somewhat differently:
I left out the has output axiom as one can't be sure a snow drift will be formed, thus:
We do have accumulation process ending a transport process right? We can then handle this as an accumulation process.
We have this in there already, under mass wasting flow or similar.
This is interesting in that it won't be a mass wasting flow but a mass wasting process. Take extra care here as this is tricky.
This would be a mass wasting flow due to the fluid behaviour, as would the wet snow avalanche term below.
Sounds reasonable.
Sure, consider some PATO qualities for axioms there. Let me know if you need imports.
This I would have as a feature rather than a material. Also add "snowdrift" as an exact synonym.
This is another feature, rather than a material.
This departs from the definition pattern, but until we figure out a good hierarchy this will do (add something to this effect as an editor's note). Is a snowdrift a snow patch?
Similar to above:
The way the comment on 'ends during' is formulated, I think this is for processes and not material entities. I'd remove that for now, perhaps adding a note that we should find out how to express that a process gets rid of a material entity. @cmungall, would you know any standard axiomatisation for this?
Minor edit
I'd add a comment that some would only say perennial if it survives two or more cycles. I'm not sure about the 'causally influenced by' axiom, please remove it for now.
I'm not sure what you mean by 'during here' - does the snowfall process have to be ongoing in order for a snowpack to exist? If not, then this definition can pertain to any snow. Further, this sounds like a material def, when a snowpack is a feature. Also, is this a particular kind of snow? Powder snow?
A move is in order, but I'd go for
This sounds okay, but I feel that it's not really what output means. I'd say that a snowdrift is |
This was referenced Apr 8, 2017
kaiiam
added some commits
Apr 8, 2017
|
@kaiiam are we ready to merge? |
pbuttigieg
added
to Complete in cryophile
Apr 13, 2017
pbuttigieg
moved
from Complete to Pull requests in cryophile
Apr 13, 2017
|
@pbuttigieg I believe so. |
pbuttigieg
approved these changes
Apr 14, 2017
Thanks @kaiiam! We're ready to merge this now - there's still refinement that can be done, but the core merge is looking good!

kaiiam commentedMar 31, 2017
•
edited
see #483 for details.