Handle vector width abi #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
approved these changes
Apr 18, 2022
Member
vchuravy
left a comment
vchuravy
left a comment
There was a problem hiding this comment.
Modulo removal of debug output and test passing
tgymnich
approved these changes
Apr 18, 2022
wsmoses
force-pushed
the
vwidth
branch
4 times, most recently
from
c013641 to
b21609d
Compare
vchuravy
reviewed
Apr 19, 2022
vchuravy
reviewed
Apr 19, 2022
vchuravy
reviewed
Apr 19, 2022
vchuravy
reviewed
Apr 19, 2022
vchuravy
reviewed
Apr 19, 2022
vchuravy
reviewed
Apr 19, 2022
vchuravy
reviewed
Apr 19, 2022
wsmoses
force-pushed
the
vwidth
branch
3 times, most recently
from
2e611a9 to
6af233c
Compare
vchuravy
requested changes
Apr 27, 2022
wsmoses
force-pushed
the
vwidth
branch
2 times, most recently
from
a7c144a to
d1020a9
Compare
vchuravy
requested changes
May 2, 2022
Member
vchuravy
left a comment
vchuravy
left a comment
There was a problem hiding this comment.
Needs docs for new API functions e.g. gradient and jacobian.
Also can we split out the bug fixes into separate PRs? Or at least one PR with the bug fixes that is backportable to the 0.9 release?
vchuravy
reviewed
May 3, 2022
vchuravy
reviewed
May 3, 2022
vchuravy
approved these changes
May 3, 2022
Member
vchuravy
left a comment
vchuravy
left a comment
There was a problem hiding this comment.
Will need to add a documenter preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires EnzymeAD/Enzyme#615