From 73f57e5f71281fd0f943482b3f6eb1c186e660b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mos=C3=A8=20Giordano?= Date: Mon, 1 Sep 2025 23:13:46 +0100 Subject: [PATCH 1/3] [CI] Run job updating MLIR bindings on Julia v1.11 --- .github/workflows/regenerate-mlir-bindings.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regenerate-mlir-bindings.yml b/.github/workflows/regenerate-mlir-bindings.yml index 3e6f993656..f2489ce7f9 100644 --- a/.github/workflows/regenerate-mlir-bindings.yml +++ b/.github/workflows/regenerate-mlir-bindings.yml @@ -14,7 +14,7 @@ jobs: steps: - uses: julia-actions/setup-julia@v2 with: - version: '1.10' + version: '1.11' - uses: julia-actions/cache@v2 - uses: bazel-contrib/setup-bazel@0.15.0 name: Set up Bazel From 5153f237915d26803bdda5b4faa67a21ab557c96 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mos=C3=A8=20Giordano?= Date: Mon, 1 Sep 2025 23:14:06 +0100 Subject: [PATCH 2/3] Temporarily point `Clang` to Billy's branch in `deps/ReactantExtra` --- deps/ReactantExtra/Project.toml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/deps/ReactantExtra/Project.toml b/deps/ReactantExtra/Project.toml index 4e1c9287ec..a05265fc63 100644 --- a/deps/ReactantExtra/Project.toml +++ b/deps/ReactantExtra/Project.toml @@ -4,3 +4,6 @@ BinaryBuilderBase = "7f725544-6523-48cd-82d1-3fa08ff4056e" [compat] Clang = "0.18" + +[sources] +Clang = {url = "https://github.com/wsmoses/Clang.jl", rev = "patch-1"} From 84a3cfdea1112080b6950f1e77b9d0771a32bd82 Mon Sep 17 00:00:00 2001 From: William Moses Date: Mon, 1 Sep 2025 17:30:16 -0500 Subject: [PATCH 3/3] Fix formatting in optional attributes handling --- deps/ReactantExtra/tblgen/jl-generators.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/ReactantExtra/tblgen/jl-generators.cc b/deps/ReactantExtra/tblgen/jl-generators.cc index 4853a3dd1a..a3e871935c 100644 --- a/deps/ReactantExtra/tblgen/jl-generators.cc +++ b/deps/ReactantExtra/tblgen/jl-generators.cc @@ -365,7 +365,7 @@ end if (optional) { optionals += llvm::formatv( - R"(!isnothing({0}) && push!(attributes, namedattribute("{0}", {1})) + R"(!isnothing({1}) && push!(attributes, namedattribute("{0}", {1})) )", attributename, sanitizedname); defaultvalue = "=nothing";