Skip to content

feat: add support for NNlib make causal mask #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wsmoses merged 1 commit into from
Nov 9, 2024
Merged

feat: add support for NNlib make causal mask #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ext/ReactantNNlibExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module ReactantNNlibExt
using NNlib
using Reactant:
Reactant, TracedRArray, AnyTracedRArray, materialize_traced_array, MLIR, TracedRNumber
using LinearAlgebra: LinearAlgebra, triu

for (jlop, hloop) in (
(:(NNlib.tanh_fast), :tanh),
Expand Down Expand Up @@ -280,4 +281,19 @@ function NNlib.pad_constant(
return TracedRArray{T,N}((), res, size(MLIR.IR.type(res)))
end

function NNlib.make_causal_mask(x::AnyTracedRArray; dims::Int=2)
len = size(x, dims)
# directly generating booleans were causing an incorrect constant attribute generation
# but the optimized IR removes the type case so we are probably ok
mask = MLIR.IR.DenseElementsAttribute(collect(triu(fill(1, (len, len)))'))
return Reactant.promote_to(
TracedRArray{Bool,2},
TracedRArray{Int,2}(
(),
MLIR.IR.result(MLIR.Dialects.stablehlo.constant(; value=mask), 1),
(len, len),
),
)
end

end # module ReactantNNlibExt
10 changes: 10 additions & 0 deletions test/nn/nnlib.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,3 +163,13 @@ end

@test @jit(NNlib.pad_constant(x_ra, (1, 1))) ≈ NNlib.pad_constant(x, (1, 1))
end

@testset "make_causal_mask" begin
x = rand(2, 10)
x_ra = Reactant.ConcreteRArray(x)

@test @jit(NNlib.make_causal_mask(x_ra)) ≈ NNlib.make_causal_mask(x)

causal_mask2(x) = NNlib.make_causal_mask(x; dims=1)
@test @jit(causal_mask2(x_ra)) ≈ causal_mask2(x)
end
Loading