Skip to content

Conversation

@avik-pal
Copy link
Collaborator

@avik-pal avik-pal commented Mar 9, 2025

No description provided.

Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible to add a quick test that would be good

traced_args_to_shardings = OrderedIdDict()
for (k, v) in seen_args
if hasfield(typeof(k), :sharding)
if (k isa AbstractConcreteNumber || k isa AbstractConcreteArray) &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR: LoadError: UndefVarError: `AbstractConcreteNumber` not defined in `Reactant.TracedUtils`

@avik-pal
Copy link
Collaborator Author

avik-pal commented Mar 9, 2025

If possible to add a quick test that would be good

I am not even sure why we are getting non-concrete arrays in that dict 😓

@wsmoses
Copy link
Member

wsmoses commented Mar 9, 2025

oh we should expect to see non concrete rarrays (i.e. for a mutable struct of inner values, since we need to avoid infinite recursion)

avik-pal and others added 4 commits March 10, 2025 15:29
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@giordano
Copy link
Member

https://github.com/EnzymeAD/Reactant.jl/actions/runs/13768515337/job/38501002328?pr=871#step:9:524

[2150] signal 11 (128): Segmentation fault
in expression starting at /home/runner/work/Reactant.jl/Reactant.jl/ext/ReactantPythonCallExt.jl:3
pymalloc_alloc at /usr/local/src/conda/python-3.12.9/Objects/obmalloc.c:1544 [inlined]
_PyObject_Malloc at /usr/local/src/conda/python-3.12.9/Objects/obmalloc.c:1564 [inlined]
PyObject_Malloc at /usr/local/src/conda/python-3.12.9/Objects/obmalloc.c:801 [inlined]
_PyLong_New at /usr/local/src/conda/python-3.12.9/Objects/longobject.c:158 [inlined]
x_add at /usr/local/src/conda/python-3.12.9/Objects/longobject.c:3418
binary_op1 at /usr/local/src/conda/python-3.12.9/Objects/abstract.c:882 [inlined]
PyNumber_Add at /usr/local/src/conda/python-3.12.9/Objects/abstract.c:1062
fill_time at /usr/local/src/conda/python-3.12.9/Modules/posixmodule.c:2472
_pystat_fromstructstat at /usr/local/src/conda/python-3.12.9/Modules/posixmodule.c:2597
posix_do_stat at /usr/local/src/conda/python-3.12.9/Modules/posixmodule.c:2722
os_stat_impl at /usr/local/src/conda/python-3.12.9/Modules/posixmodule.c:3069 [inlined]
os_stat at /usr/local/src/conda/python-3.12.9/Modules/clinic/posixmodule.c.h:104
_PyEval_EvalFrameDefault at /home/conda/feedstock_root/build_artifacts/python-split_1741127329023/work/build-shared/Python/bytecodes.c:2975
_PyEval_EvalFrame at /usr/local/src/conda/python-3.12.9/Include/internal/pycore_ceval.h:89 [inlined]
_PyEval_Vector at /usr/local/src/conda/python-3.12.9/Python/ceval.c:1685 [inlined]
_PyFunction_Vectorcall at /usr/local/src/conda/python-3.12.9/Objects/call.c:419 [inlined]
_PyObject_FastCallDictTstate at /usr/local/src/conda/python-3.12.9/Objects/call.c:133
_PyObject_Call_Prepend at /usr/local/src/conda/python-3.12.9/Objects/call.c:508 [inlined]
slot_tp_init at /usr/local/src/conda/python-3.12.9/Objects/typeobject.c:9035
type_call at /usr/local/src/conda/python-3.12.9/Objects/typeobject.c:1679 [inlined]
_PyObject_MakeTpCall at /usr/local/src/conda/python-3.12.9/Objects/call.c:240
_PyEval_EvalFrameDefault at /home/conda/feedstock_root/build_artifacts/python-split_1741127329023/work/build-shared/Python/bytecodes.c:2715
_PyObject_VectorcallTstate at /usr/local/src/conda/python-3.12.9/Include/internal/pycore_call.h:92 [inlined]
object_vacall at /usr/local/src/conda/python-3.12.9/Objects/call.c:850
PyObject_CallMethodObjArgs at /usr/local/src/conda/python-3.12.9/Objects/call.c:911
import_find_and_load at /usr/local/src/conda/python-3.12.9/Python/import.c:2781 [inlined]
PyImport_ImportModuleLevelObject at /usr/local/src/conda/python-3.12.9/Python/import.c:2864
builtin___import___impl at /usr/local/src/conda/python-3.12.9/Python/bltinmodule.c:275 [inlined]
builtin___import__ at /usr/local/src/conda/python-3.12.9/Python/clinic/bltinmodule.c.h:107
cfunction_vectorcall_FASTCALL_KEYWORDS at /usr/local/src/conda/python-3.12.9/Objects/methodobject.c:438
_PyObject_VectorcallTstate at /usr/local/src/conda/python-3.12.9/Include/internal/pycore_call.h:92 [inlined]
_PyObject_CallFunctionVa at /usr/local/src/conda/python-3.12.9/Objects/call.c:562 [inlined]
PyObject_CallFunction at /usr/local/src/conda/python-3.12.9/Objects/call.c:584
PyImport_Import at /usr/local/src/conda/python-3.12.9/Python/import.c:3050
PyImport_Import at /home/runner/.julia/packages/PythonCall/WMWY0/src/C/pointers.jl:303
unknown function (ip: 0x7fc4c25a3c85)
unknown function (ip: 0x7fc4c25a2b1c)
unknown function (ip: 0x7fc4c25a2a2c)
macro expansion at /home/runner/.julia/packages/PythonCall/WMWY0/src/Core/Py.jl:132 [inlined]
pyimport at /home/runner/.julia/packages/PythonCall/WMWY0/src/Core/builtins.jl:1561
init_juliacall at /home/runner/.julia/packages/PythonCall/WMWY0/src/Core/juliacall.jl:26
unknown function (ip: 0x7fc4c25b263f)
unknown function (ip: 0x7fc4c259f89c)
unknown function (ip: 0x7fc4c259f824)
__init__ at /home/runner/.julia/packages/PythonCall/WMWY0/src/Core/Core.jl:45
unknown function (ip: 0x7fc4c259f6af)
jl_apply at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/julia.h:2157 [inlined]
jl_module_run_initializer at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:76
run_module_init at ./loading.jl:1378
register_restored_modules at ./loading.jl:1366
#_include_from_serialized#1082 at ./loading.jl:1254
_include_from_serialized at ./loading.jl:1210 [inlined]
_include_from_serialized at ./loading.jl:1210 [inlined]
#_require_search_from_serialized#1105 at ./loading.jl:2057
_require_search_from_serialized at ./loading.jl:1969
jfptr__require_search_from_serialized_44869.1 at /opt/hostedtoolcache/julia/1.11.3/x64/lib/julia/sys.so (unknown line)
_require at ./loading.jl:2527
__require_prelocked at ./loading.jl:2388
jfptr___require_prelocked_71365.1 at /opt/hostedtoolcache/julia/1.11.3/x64/lib/julia/sys.so (unknown line)
jl_apply at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/julia.h:2157 [inlined]
jl_f__call_in_world at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/builtins.c:894
#invoke_in_world#3 at ./essentials.jl:1089 [inlined]
invoke_in_world at ./essentials.jl:1086 [inlined]
_require_prelocked at ./loading.jl:2375
macro expansion at ./loading.jl:2314 [inlined]
macro expansion at ./lock.jl:273 [inlined]
__require at ./loading.jl:2271
jfptr___require_71296.1 at /opt/hostedtoolcache/julia/1.11.3/x64/lib/julia/sys.so (unknown line)
jl_apply at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/julia.h:2157 [inlined]
jl_f__call_in_world at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/builtins.c:894
#invoke_in_world#3 at ./essentials.jl:1089 [inlined]
invoke_in_world at ./essentials.jl:1086 [inlined]
require at ./loading.jl:2260
jfptr_require_71293.1 at /opt/hostedtoolcache/julia/1.11.3/x64/lib/julia/sys.so (unknown line)
jl_apply at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/julia.h:2157 [inlined]
call_require at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:486 [inlined]
eval_import_path at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:523
jl_toplevel_eval_flex at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:759
jl_eval_module_expr at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:215 [inlined]
jl_toplevel_eval_flex at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:743
jl_toplevel_eval_flex at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:886
ijl_toplevel_eval_in at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:994
eval at ./boot.jl:430 [inlined]
include_string at ./loading.jl:2734
_include at ./loading.jl:2794
include at ./Base.jl:557 [inlined]
include_package_for_output at ./loading.jl:2881
jfptr_include_package_for_output_72249.1 at /opt/hostedtoolcache/julia/1.11.3/x64/lib/julia/sys.so (unknown line)
jl_apply at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/julia.h:2157 [inlined]
do_call at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/interpreter.c:126
eval_value at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/interpreter.c:223
eval_stmt_value at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/interpreter.c:174 [inlined]
eval_body at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/interpreter.c:663
jl_interpret_toplevel_thunk at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/interpreter.c:821
jl_toplevel_eval_flex at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:943
jl_toplevel_eval_flex at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:886
ijl_toplevel_eval_in at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:994
eval at ./boot.jl:430 [inlined]
include_string at ./loading.jl:2734
include_string at ./loading.jl:2744 [inlined]
exec_options at ./client.jl:321
_start at ./client.jl:531
jfptr__start_73609.1 at /opt/hostedtoolcache/julia/1.11.3/x64/lib/julia/sys.so (unknown line)
jl_apply at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/julia.h:2157 [inlined]
true_main at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/jlapi.c:900
jl_repl_entrypoint at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/jlapi.c:1059
main at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/cli/loader_exe.c:58
unknown function (ip: 0x7fc4db22a1c9)
__libc_start_main at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 0x4010b8)
Allocations: 15939901 (Pool: 15938106; Big: 1795); GC: 1
in expression starting at /home/runner/work/_temp/54c868d9-92b7-4682-afc1-b3bdc4a16208:3
Error: Process completed with exit code 1.

@wsmoses
Copy link
Member

wsmoses commented Mar 10, 2025

I feel like we were seeing this every so often regardless?

@wsmoses
Copy link
Member

wsmoses commented Mar 10, 2025

@avik-pal is this good to go?

@avik-pal
Copy link
Collaborator Author

Yes

@wsmoses wsmoses merged commit 9cf3325 into main Mar 10, 2025
58 of 60 checks passed
@wsmoses wsmoses deleted the avik-pal-patch-1 branch March 10, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants