-
Notifications
You must be signed in to change notification settings - Fork 38
fix: sharding check #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sharding check #871
Conversation
wsmoses
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible to add a quick test that would be good
src/TracedUtils.jl
Outdated
| traced_args_to_shardings = OrderedIdDict() | ||
| for (k, v) in seen_args | ||
| if hasfield(typeof(k), :sharding) | ||
| if (k isa AbstractConcreteNumber || k isa AbstractConcreteArray) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ERROR: LoadError: UndefVarError: `AbstractConcreteNumber` not defined in `Reactant.TracedUtils`
I am not even sure why we are getting non-concrete arrays in that dict 😓 |
|
oh we should expect to see non concrete rarrays (i.e. for a mutable struct of inner values, since we need to avoid infinite recursion) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1914d46 to
dadfbf2
Compare
|
https://github.com/EnzymeAD/Reactant.jl/actions/runs/13768515337/job/38501002328?pr=871#step:9:524 |
|
I feel like we were seeing this every so often regardless? |
|
@avik-pal is this good to go? |
|
Yes |
No description provided.