fix: auto-compile fill of concretearray #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/fill_concrete_array_view
branch
from
c0259f5 to
a5fa9fe
Compare
Collaborator
Author
|
should resolve PRONTOLab/GB-25#32 (comment) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wsmoses
approved these changes
Mar 11, 2025
jumerckx
approved these changes
Mar 11, 2025
Collaborator
jumerckx
left a comment
jumerckx
left a comment
There was a problem hiding this comment.
LGTM as well.
This fix reveals the next error for the Oceananigans code, namely permutedims!, and after that map!.
I'll clean up my code for those and make a follow up pr.
My fixes on top of these still don't make the code work though, I'm starting to think it might be easier to force building of the simulation grid on the cpu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.