From c7d1b455f0119cdd7eb7286800b4e2754ea16655 Mon Sep 17 00:00:00 2001 From: "William S. Moses" Date: Wed, 12 Mar 2025 22:01:07 -0500 Subject: [PATCH 1/3] Strip debug info on tpu --- src/Compiler.jl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Compiler.jl b/src/Compiler.jl index d1d37f3455..1194d08750 100644 --- a/src/Compiler.jl +++ b/src/Compiler.jl @@ -748,7 +748,11 @@ function compile_mlir!( if backend == "cpu" || backend == "tpu" kern = "lower-kernel{backend=cpu},canonicalize" - jit = "lower-jit{openmp=true backend=cpu},symbol-dce" + if backend == "tpu" + jit = "lower-jit{openmp=true backend=cpu},symbol-dce,strip-debuginfo" + else + jit = "lower-jit{openmp=true backend=cpu},symbol-dce" + end elseif DEBUG_KERNEL[] curesulthandler = dlsym( Reactant_jll.libReactantExtra_handle, "ReactantHandleCuResult" From ec3d35365e3fb3882f453482e76f6a6afb4af260 Mon Sep 17 00:00:00 2001 From: "William S. Moses" Date: Wed, 12 Mar 2025 22:10:40 -0500 Subject: [PATCH 2/3] Add strip debug info registration --- deps/ReactantExtra/API.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/deps/ReactantExtra/API.cpp b/deps/ReactantExtra/API.cpp index f64fd63829..108f292716 100644 --- a/deps/ReactantExtra/API.cpp +++ b/deps/ReactantExtra/API.cpp @@ -1076,11 +1076,10 @@ extern "C" void InitializePasses(MlirDialectRegistry creg) { enzyme::registerenzymexlaPasses(); // Register the standard passes we want. - mlir::registerCSEPass(); + mlir::registerTransformsPasses(); mlir::registerLowerAffinePass(); mlir::registerSCCPPass(); mlir::registerInlinerPass(); - mlir::registerCanonicalizerPass(); mlir::registerSymbolDCEPass(); mlir::registerLoopInvariantCodeMotionPass(); mlir::registerConvertSCFToOpenMPPass(); From 412134dcf58f704e7ef56491368670fedbbb05c6 Mon Sep 17 00:00:00 2001 From: William Moses Date: Wed, 12 Mar 2025 22:12:44 -0500 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- src/Compiler.jl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Compiler.jl b/src/Compiler.jl index 1194d08750..1866e60a7f 100644 --- a/src/Compiler.jl +++ b/src/Compiler.jl @@ -748,10 +748,10 @@ function compile_mlir!( if backend == "cpu" || backend == "tpu" kern = "lower-kernel{backend=cpu},canonicalize" - if backend == "tpu" - jit = "lower-jit{openmp=true backend=cpu},symbol-dce,strip-debuginfo" + if backend == "tpu" + jit = "lower-jit{openmp=true backend=cpu},symbol-dce,strip-debuginfo" else - jit = "lower-jit{openmp=true backend=cpu},symbol-dce" + jit = "lower-jit{openmp=true backend=cpu},symbol-dce" end elseif DEBUG_KERNEL[] curesulthandler = dlsym(