New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Moment deprecation warning #1371

Open
wants to merge 1 commit into
base: development
from

Conversation

Projects
None yet
3 participants
@c1phr

c1phr commented Oct 14, 2015

Moment deprecated calling moment() without formatting information, and the defaultDate setup was calling getMoment() without ever having fired initFormatting(). This threw an ugly deprecation warning in the console from Moment.

An example can be seen at this jsFiddle: https://jsfiddle.net/gcnzb1vj/

This fix will trigger initFormatting() before trying to call getMoment() as part of the default date setup.

Fix for Moment deprecation warning
Moment deprecated calling moment() without formatting information, and the
defaultDate setup was calling getMoment() without ever having fired initFormatting(). This threw an ugly deprecation warning in
the console from Moment.
@ssareli

This comment has been minimized.

ssareli commented Dec 22, 2016

Can we get this merged?

@dmitryt

This comment has been minimized.

dmitryt commented Nov 20, 2017

Any update about this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment